You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/07/14 22:49:18 UTC

Re: Review Request 60852: ATLAS-1947: Improvements for ATLAS-1880 and some change to AtlasSearchResult

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60852/
-----------------------------------------------------------

(Updated July 14, 2017, 10:49 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.


Summary (updated)
-----------------

ATLAS-1947: Improvements for ATLAS-1880 and some change to AtlasSearchResult


Bugs: ATLAS-1947
    https://issues.apache.org/jira/browse/ATLAS-1947


Repository: atlas


Description
-------

The search result will now include the following

1. guid -> referredEntity
2. Any valid attribute found in the search filter will be included for each entity in the result


Diffs
-----

  intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 9513dcb1 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 30855dcf 
  repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 030a9577 
  repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 5068fa5f 
  repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/GremlinStep.java 1056b3ef 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java 0f91b2d1 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/SolrStep.java 6a5dd5ae 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 4ac00a32 
  repository/src/main/java/org/apache/atlas/util/SearchTracker.java 15a8c203 
  repository/src/test/java/org/apache/atlas/TestModules.java d0da0303 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 1a9f57a3 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java dde300e2 


Diff: https://reviews.apache.org/r/60852/diff/3/


Testing
-------

mvn clean package runs successfully


Thanks,

Apoorv Naik


Re: Review Request 60852: ATLAS-1947: Improvements for ATLAS-1880 and some change to AtlasSearchResult

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60852/#review180602
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On July 14, 2017, 10:49 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60852/
> -----------------------------------------------------------
> 
> (Updated July 14, 2017, 10:49 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1947
>     https://issues.apache.org/jira/browse/ATLAS-1947
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The search result will now include the following
> 
> 1. guid -> referredEntity
> 2. Any valid attribute found in the search filter will be included for each entity in the result
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 9513dcb1 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 30855dcf 
>   repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 030a9577 
>   repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 5068fa5f 
>   repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/GremlinStep.java 1056b3ef 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java 0f91b2d1 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/SolrStep.java 6a5dd5ae 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 4ac00a32 
>   repository/src/main/java/org/apache/atlas/util/SearchTracker.java 15a8c203 
>   repository/src/test/java/org/apache/atlas/TestModules.java d0da0303 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 1a9f57a3 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java dde300e2 
> 
> 
> Diff: https://reviews.apache.org/r/60852/diff/3/
> 
> 
> Testing
> -------
> 
> mvn clean package runs successfully
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>