You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Jörg Schaible <jo...@scalaris.com> on 2011/07/11 08:46:57 UTC
Fwd: svn commit: r1144995 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
Didn't you want to make this variable static as stated in the log?
---------------
Betreff: svn commit: r1144995 -
/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
Absender: ggregory-1oDqGaOF3Lkdnm+yROfE0A@public.gmane.org
Datum: Mon, 11 Jul 2011 00:53:10 +0000
Newsgruppe: gmane.comp.jakarta.commons.scm
Author: ggregory
Date: Mon Jul 11 00:53:09 2011
New Revision: 1144995
URL: http://svn.apache.org/viewvc?rev=1144995&view=rev
Log:
Should be a static variable.
Modified:
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
Modified:
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java?rev=1144995&r1=1144994&r2=1144995&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
(original)
+++
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
Mon Jul 11 00:53:09 2011
@@ -508,7 +508,7 @@ public class DurationFormatUtilsTest ext
//bruteForce(1996, 1, 29, "M", Calendar.MONTH); // this will fail
}
- private int FOUR_YEARS = 365 * 3 + 366;
+ private final int FOUR_YEARS = 365 * 3 + 366;
// Takes a minute to run, so generally turned off
// public void testBrutally() {
--------------- Weitergeleitete Nachricht (Ende)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1144995 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
Posted by Gary Gregory <ga...@gmail.com>.
Yes, thank you. Done in SVN.
Gary
On Mon, Jul 11, 2011 at 2:46 AM, Jörg Schaible
<jo...@scalaris.com>wrote:
>
> Didn't you want to make this variable static as stated in the log?
>
> ---------------
>
> Betreff: svn commit: r1144995 -
>
> /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
> Absender: ggregory-1oDqGaOF3Lkdnm+yROfE0A@public.gmane.org
> Datum: Mon, 11 Jul 2011 00:53:10 +0000
> Newsgruppe: gmane.comp.jakarta.commons.scm
>
> Author: ggregory
> Date: Mon Jul 11 00:53:09 2011
> New Revision: 1144995
>
> URL: http://svn.apache.org/viewvc?rev=1144995&view=rev
> Log:
> Should be a static variable.
>
> Modified:
>
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
>
> Modified:
>
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
> URL:
>
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java?rev=1144995&r1=1144994&r2=1144995&view=diff
>
> ==============================================================================
> ---
>
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
> (original)
> +++
>
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
> Mon Jul 11 00:53:09 2011
> @@ -508,7 +508,7 @@ public class DurationFormatUtilsTest ext
> //bruteForce(1996, 1, 29, "M", Calendar.MONTH); // this will fail
> }
>
> - private int FOUR_YEARS = 365 * 3 + 366;
> + private final int FOUR_YEARS = 365 * 3 + 366;
>
> // Takes a minute to run, so generally turned off
> // public void testBrutally() {
>
>
>
> --------------- Weitergeleitete Nachricht (Ende)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
Thank you,
Gary
http://garygregory.wordpress.com/
http://garygregory.com/
http://people.apache.org/~ggregory/
http://twitter.com/GaryGregory