[jira] [Commented] (DAFFODIL-1512) dfdl prefix properties on dfdl annotation elements should generate useful diagnostic

["Dave Thompson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DAFFODIL-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283777#comment-17283777 ] 

Dave Thompson commented on DAFFODIL-1512:
-----------------------------------------

Not much info here to help verify if this was resolved.

Could not find any specific tests the test for this.

However, I think the issue has been resolved. I temporarily modified existing tests with the dfdl:format, adding the prefix to a property and then executed the test. An error similar to the following is displayed:

[error] Test org.apache.daffodil.section00.general.TestParseUnparsePolicy.test_bb failed: org.apache.daffodil.tdml.TDMLExceptionImpl: org.xml.sax.SAXParseException; systemId: file:/home/dthompson/incubator-daffodil/daffodil-test/target/scala-2.12/test-classes/org/apache/daffodil/section00/general/parseUnparsePolicy.tdml; lineNumber: 31; columnNumber: 81; cvc-complex-type.3.2.2: Attribute 'dfdl:lengthKind' is not allowed to appear in element 'dfdl:format'.

Should add tests verify this.

 

> dfdl prefix properties on dfdl annotation elements should generate useful diagnostic
> ------------------------------------------------------------------------------------
>
>                 Key: DAFFODIL-1512
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-1512
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Diagnostics, Front End, Usability
>            Reporter: Mike Beckerle
>            Priority: Major
>             Fix For: 3.1.0
>
>
> A common mistake is to move short-form annotations with the dfdl: prefix from elements into the dfdl:format annotation. But then one forgets to remove the prefix dfdl: since the attributes of the dfdl:format annotation are not prefixed. So this is an error: {code}
> <dfdl:format dfdl:lengthKind="delimited" ..../>
> {code}
> When what was intended is{code}
> <dfdl:format lengthKind="delimited".... />
> {code}
> Daffodil should issue a specific diagnostic whenever it finds dfdl: prefixed attributes in the annotation elements dfdl:format, dfdl:element, dfdl:simpleType, dfdl:sequence, dfdl:choice, etc. 
> It should point out specifically that the author probably wanted to remove the prefix dfdl:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)