You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "xiangyuf (via GitHub)" <gi...@apache.org> on 2024/05/20 07:32:38 UTC

[I] [Feature] Improve the tryCommitOnce behavior in FileStoreCommitImpl [paimon]

xiangyuf opened a new issue, #3351:
URL: https://github.com/apache/paimon/issues/3351

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/paimon/issues) and found nothing similar.
   
   
   ### Motivation
   
   When using dedicated compactions in production, we've found the write only job and compact job will failover every 2 or 3 days even if the remote filesystem support atomic rename operation.
   
   The main cause is the FileAlreadyExistsException:
   ![image](https://github.com/apache/paimon/assets/3021821/fef85c30-17cc-41c4-b409-ba534f2841ca)
   
   Checking with recent Hadoop API Rename implementation, we found the rename api will return FileAlreadyExistsException for rename api instead of false by default.
   https://github.com/apache/hadoop/blob/branch-3.3.6/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java
   ![image](https://github.com/apache/paimon/assets/3021821/57372e8f-a1ec-4979-ab29-00d9780adf92)
   
   IMHO, this can be improved by catch certain exceptions in tryCommitOnce and return false to upper caller. 
   
   
   
   
   
   ### Solution
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Feature] Improve the tryCommitOnce behavior in FileStoreCommitImpl [paimon]

Posted by "xiangyuf (via GitHub)" <gi...@apache.org>.
xiangyuf commented on issue #3351:
URL: https://github.com/apache/paimon/issues/3351#issuecomment-2124105005

   Hi @JingsongLi, WDYT about this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Feature] Improve the tryCommitOnce behavior in FileStoreCommitImpl [paimon]

Posted by "tsreaper (via GitHub)" <gi...@apache.org>.
tsreaper commented on issue #3351:
URL: https://github.com/apache/paimon/issues/3351#issuecomment-2240949290

   Could you explain what kinds of exceptions you would like to catch, and where you would like to catch them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org