You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "uschindler (via GitHub)" <gi...@apache.org> on 2023/06/29 12:00:10 UTC

[GitHub] [lucene] uschindler opened a new pull request, #12404: Remove and add some legacy java.util classes to forbiddenapis (Stack, Hashtable, Vector)

uschindler opened a new pull request, #12404:
URL: https://github.com/apache/lucene/pull/12404

   I noticed on some other PR that some classes (especially `java.util.Stack`) are used in Lucene code although they are really legacy from Java 1.0. The problem with them is that they are synchronized. Stack is used in some preformance critical code.
   
   This PR adds them to forbiddenapis and fixes usage.
   
   There is a small problem with forbiddenapis, that it triggers on Hashtable for declarations of `java.util.Properties` (as this one extends from `Hashtable` as implementation detail. For now I commented the forbidden rule.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler merged pull request #12404: Remove usage and add some legacy java.util classes to forbiddenapis (Stack, Hashtable, Vector)

Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler merged PR #12404:
URL: https://github.com/apache/lucene/pull/12404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org