[GitHub] [doris] morrySnow commented on a diff in pull request #19169: [fix](fe)fix bug if left table is empty and there are multiple right tables need do bucket shuffle to left side

["morrySnow (via GitHub)" <gi...@apache.org>]

morrySnow commented on code in PR #19169:
URL: https://github.com/apache/doris/pull/19169#discussion_r1179403665


##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -1357,8 +1357,8 @@ private void computeFragmentExecParams() throws Exception {
 
                 // when left table is empty, it's bucketset is empty.
                 // set right table destination address to the address of left table
-                if (destParams.instanceExecParams.size() == 1
-                        && destParams.instanceExecParams.get(0).bucketSeqSet.isEmpty()) {
+                if (destParams.instanceExecParams.size() == 1 && (bucketNum == 0
+                        || destParams.instanceExecParams.get(0).bucketSeqSet.isEmpty())) {

Review Comment:
   why add back `destParams.instanceExecParams.get(0).bucketSeqSet.isEmpty()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org