You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by jun aoki <ju...@gmail.com> on 2014/09/27 00:19:34 UTC
does test-patch require javadoc examination?
Hi Ambari devs,
The test-patch job fails currently due to mvn javadoc:javadoc fails.
https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/45/console
More specifically this command fails.
{code}
mvn clean test javadoc:javadoc -DskipTests -Pdocs -DAmbariPatchProcess
{code}
and the error is here
https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/45/artifact/patch-work/trunkJavadocWarnings.txt
This is all about a bunch of classic compilation errors.
{code}
[ERROR] Exit code: 1 -
/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/main/java/org/apache/ambari/server/api/MethodOverrideFilter.java:21:
error: package org.springframework.http does not exist
[ERROR] import org.springframework.http.HttpMethod;
[ERROR] ^
{code}
which, though, can not be observed in the trunk-commit job.
https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/396/
The commit job currently does not provide javadoc either, so there
should be some class path issue which is different from the regular
build.
The question is, do we provide javadoc as well as the other rpms? Has
anyone tested mvn javadoc:javadoc works? (it fails on my test env as
well)
--
-jun
Re: does test-patch require javadoc examination?
Posted by Yusaku Sako <yu...@hortonworks.com>.
Makes sense. Thanks Jun.
Yusaku
On Fri, Sep 26, 2014 at 4:05 PM, jun aoki <ju...@gmail.com> wrote:
> Yusaku, thank you for letting me know. I'm going to disable javadoc check
> for now in the test-patch.
> Let's have an epic and discuss how javadoc should be provided too. The
> errors I posted should be cleaned and taken care too before we extend the
> test-patch coverage.
>
> On Fri, Sep 26, 2014 at 3:27 PM, Yusaku Sako <yu...@hortonworks.com> wrote:
>
>> Jun,
>>
>> No, we have not been building/testing javadoc, but it would be great to
>> add.
>>
>> Yusaku
>>
>>
>> On Fri, Sep 26, 2014 at 3:19 PM, jun aoki <ju...@gmail.com> wrote:
>> > Hi Ambari devs,
>> >
>> > The test-patch job fails currently due to mvn javadoc:javadoc fails.
>> >
>> >
>> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/45/console
>> >
>> >
>> > More specifically this command fails.
>> >
>> > {code}
>> >
>> > mvn clean test javadoc:javadoc -DskipTests -Pdocs -DAmbariPatchProcess
>> >
>> > {code}
>> >
>> >
>> > and the error is here
>> >
>> >
>> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/45/artifact/patch-work/trunkJavadocWarnings.txt
>> >
>> >
>> > This is all about a bunch of classic compilation errors.
>> >
>> > {code}
>> >
>> > [ERROR] Exit code: 1 -
>> >
>> /home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/main/java/org/apache/ambari/server/api/MethodOverrideFilter.java:21:
>> > error: package org.springframework.http does not exist
>> > [ERROR] import org.springframework.http.HttpMethod;
>> > [ERROR] ^
>> >
>> > {code}
>> >
>> > which, though, can not be observed in the trunk-commit job.
>> >
>> >
>> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/396/
>> >
>> > The commit job currently does not provide javadoc either, so there
>> > should be some class path issue which is different from the regular
>> > build.
>> >
>> > The question is, do we provide javadoc as well as the other rpms? Has
>> > anyone tested mvn javadoc:javadoc works? (it fails on my test env as
>> > well)
>> >
>> >
>> >
>> > --
>> > -jun
>>
>> --
>> CONFIDENTIALITY NOTICE
>> NOTICE: This message is intended for the use of the individual or entity to
>> which it is addressed and may contain information that is confidential,
>> privileged and exempt from disclosure under applicable law. If the reader
>> of this message is not the intended recipient, you are hereby notified that
>> any printing, copying, dissemination, distribution, disclosure or
>> forwarding of this communication is strictly prohibited. If you have
>> received this communication in error, please contact the sender immediately
>> and delete it from your system. Thank You.
>>
>
>
>
> --
> -jun
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
Re: does test-patch require javadoc examination?
Posted by jun aoki <ju...@gmail.com>.
Yusaku, thank you for letting me know. I'm going to disable javadoc check
for now in the test-patch.
Let's have an epic and discuss how javadoc should be provided too. The
errors I posted should be cleaned and taken care too before we extend the
test-patch coverage.
On Fri, Sep 26, 2014 at 3:27 PM, Yusaku Sako <yu...@hortonworks.com> wrote:
> Jun,
>
> No, we have not been building/testing javadoc, but it would be great to
> add.
>
> Yusaku
>
>
> On Fri, Sep 26, 2014 at 3:19 PM, jun aoki <ju...@gmail.com> wrote:
> > Hi Ambari devs,
> >
> > The test-patch job fails currently due to mvn javadoc:javadoc fails.
> >
> >
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/45/console
> >
> >
> > More specifically this command fails.
> >
> > {code}
> >
> > mvn clean test javadoc:javadoc -DskipTests -Pdocs -DAmbariPatchProcess
> >
> > {code}
> >
> >
> > and the error is here
> >
> >
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/45/artifact/patch-work/trunkJavadocWarnings.txt
> >
> >
> > This is all about a bunch of classic compilation errors.
> >
> > {code}
> >
> > [ERROR] Exit code: 1 -
> >
> /home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/main/java/org/apache/ambari/server/api/MethodOverrideFilter.java:21:
> > error: package org.springframework.http does not exist
> > [ERROR] import org.springframework.http.HttpMethod;
> > [ERROR] ^
> >
> > {code}
> >
> > which, though, can not be observed in the trunk-commit job.
> >
> >
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/396/
> >
> > The commit job currently does not provide javadoc either, so there
> > should be some class path issue which is different from the regular
> > build.
> >
> > The question is, do we provide javadoc as well as the other rpms? Has
> > anyone tested mvn javadoc:javadoc works? (it fails on my test env as
> > well)
> >
> >
> >
> > --
> > -jun
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.
>
--
-jun
Re: does test-patch require javadoc examination?
Posted by Yusaku Sako <yu...@hortonworks.com>.
Jun,
No, we have not been building/testing javadoc, but it would be great to add.
Yusaku
On Fri, Sep 26, 2014 at 3:19 PM, jun aoki <ju...@gmail.com> wrote:
> Hi Ambari devs,
>
> The test-patch job fails currently due to mvn javadoc:javadoc fails.
>
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/45/console
>
>
> More specifically this command fails.
>
> {code}
>
> mvn clean test javadoc:javadoc -DskipTests -Pdocs -DAmbariPatchProcess
>
> {code}
>
>
> and the error is here
>
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/45/artifact/patch-work/trunkJavadocWarnings.txt
>
>
> This is all about a bunch of classic compilation errors.
>
> {code}
>
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/main/java/org/apache/ambari/server/api/MethodOverrideFilter.java:21:
> error: package org.springframework.http does not exist
> [ERROR] import org.springframework.http.HttpMethod;
> [ERROR] ^
>
> {code}
>
> which, though, can not be observed in the trunk-commit job.
>
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/396/
>
> The commit job currently does not provide javadoc either, so there
> should be some class path issue which is different from the regular
> build.
>
> The question is, do we provide javadoc as well as the other rpms? Has
> anyone tested mvn javadoc:javadoc works? (it fails on my test env as
> well)
>
>
>
> --
> -jun
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.