You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/13 03:11:32 UTC
[GitHub] [logging-log4j2] carterkozak opened a new pull request #697: [idea & example, request for input] Thoughts on using a code formatter?
carterkozak opened a new pull request #697:
URL: https://github.com/apache/logging-log4j2/pull/697
_This pr is meant only as an example for discussion_
What do you think about using a code formatter? In my experience, it makes reviews easier, avoids unnecessary style commits later on, and makes cherry-picking easier as style cannot diverge between branches that use the same formatter.
The formatter would allow us to make use of automation tooling without worrying about ruining formatting across the codebase.
Downside is that it doesn't allow for the formatter to be turned off for specific blocks of code, and doesn't support configuration.
Existing changes are likely to merge conflict, however that can be resolved by running the formatter on the change, creating a new commit based on the diff, and applying that.
The formatter requires some flags to work correctly on JDK17: https://github.com/diffplug/spotless/tree/main/plugin-maven#palantir-java-format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #697: [idea & example, request for input] Thoughts on using a code formatter?
Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #697:
URL: https://github.com/apache/logging-log4j2/pull/697#issuecomment-1011817999
This scares the heck out of me. 1,995 files modified means no human could review this. Gary used to (still does?) use tools to do formatting and invariably would change a piece of code and break it. For the life of me I can't recall what class that was but it happened at least 3 times.
So I get leery of tooling that creates PRs that no human could reasonably review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] carterkozak closed pull request #697: [idea & example, request for input] Thoughts on using a code formatter?
Posted by GitBox <gi...@apache.org>.
carterkozak closed pull request #697:
URL: https://github.com/apache/logging-log4j2/pull/697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #697: [idea & example, request for input] Thoughts on using a code formatter?
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #697:
URL: https://github.com/apache/logging-log4j2/pull/697#issuecomment-1012258440
The Eclipse formatter has so many options that it's dizzying. I'm sure we
can bend it to our will ;-)
Gary
On Thu, Jan 13, 2022, 09:24 Carter Kozak ***@***.***> wrote:
> I'm not suggesting merging anything that formats the entire codebase in
> one go, this was meant as an example of the result before we commit to
> going down that path. Rollout is another beast, it can be done by applying
> constraints to files as they're modified rather than changing the world at
> once.
>
> Committing to a particular formatter can be difficult because it
> front-loads the style bikeshedding which it eliminates later on. It may not
> be worthwhile, that's why I brought it up for discussion :-)
>
> A lot of folks use the eclipse formatter, I've never found a configuration
> which works reasonably in all cases (lots of unnatural line breaks in
> unexpected places, but it may be better now).
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/logging-log4j2/pull/697#issuecomment-1012183850>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJB6N5QDVP5KW7Y2GJAD6TUV3ODTANCNFSM5L2VROLA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #697: [idea & example, request for input] Thoughts on using a code formatter?
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #697:
URL: https://github.com/apache/logging-log4j2/pull/697#issuecomment-1011749927
FWIW, in Eclipse at least you can use a customizable comment to disable the
formatted for specific areas like this:
...
// @formatter:off
...
// this won't be formatted
...
// @formatter:on
Gary
On Wed, Jan 12, 2022, 22:11 Carter Kozak ***@***.***> wrote:
> *This pr is meant only as an example for discussion*
>
> What do you think about using a code formatter? In my experience, it makes
> reviews easier, avoids unnecessary style commits later on, and makes
> cherry-picking easier as style cannot diverge between branches that use the
> same formatter.
> The formatter would allow us to make use of automation tooling without
> worrying about ruining formatting across the codebase.
>
> Downside is that it doesn't allow for the formatter to be turned off for
> specific blocks of code, and doesn't support configuration.
> Existing changes are likely to merge conflict, however that can be
> resolved by running the formatter on the change, creating a new commit
> based on the diff, and applying that.
> The formatter requires some flags to work correctly on JDK17:
> https://github.com/diffplug/spotless/tree/main/plugin-maven#palantir-java-format
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/logging-log4j2/pull/697
> Commit Summary
>
> - 93fd754
> <https://github.com/apache/logging-log4j2/pull/697/commits/93fd754db3f4934d62ca643331ce0ad3108e51ab>
> Apply spotless
> - 72d033d
> <https://github.com/apache/logging-log4j2/pull/697/commits/72d033d480728ccb04234e76fdb6f37c034423ff>
> Example formatted code
>
> File Changes
>
> (300 files <https://github.com/apache/logging-log4j2/pull/697/files>)
>
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/Appender.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-9bd7e5e746647686af441572a579fcce43dfea75f99f86a2a90a8bd37dcf0456>
> (4)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/AppenderSkeleton.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-cb2d7bfcc15e46ae269ffc6c52b85143434ac8fc277973d8e52c3cf73d19432e>
> (38)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/BasicConfigurator.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-b36ebf4bd34a64c4c146beb450ebda4cc865e2615d816b3f10d35bbb385ac497>
> (3)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/Category.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-b39a214b9a0d6f05d13f2c871efdc0a3dc3dc3c21e9d95e7b499c0793832c086>
> (97)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/CategoryKey.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-10cbd9ccfa38c53c64e834f1d188389bf813dc183e797cef16abc2f0a2867014>
> (4)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/ConsoleAppender.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-1291e3ae54865d5f1e7e19de9711fd00f62eb5e88979da8d607dd5a5f53272f4>
> (8)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/DefaultCategoryFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-d09a125c1c265e7f2732151d8b6a2c01eab74f4a2940502d299550ba9e8b59bc>
> (3)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/Hierarchy.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-57c7e30cee182d0335498862c7e3e1327849f2d7ecfba57039d1c6fcd78bcc96>
> (6)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/Layout.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-5c976fed21cd5b14de35efab3ae0ec97f6a520a488d7d6a27f243a8be3cb8e1c>
> (4)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/Level.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-d536a439ee79d631050f1306163e980548e8545f95dd7eafca141bab1ff36746>
> (40)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/LogManager.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-5c40470f23251d3b11785a5bdc901b5034692c025d3dcdb649f9b04ebddb53ed>
> (481)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/Logger.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-2072171c2d800e9270c6785f19fdf2be8c305e0b90f7b3c2dff2a956fb3b3599>
> (4)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/MDC.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-a3cb9478b864642cea14306abfa90913600ba2d557746217c01cd850c5702196>
> (27)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/NDC.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-7aa2a68afb0109342aee7c16b34439fa033cbb49c05d1fcf820dfd3fabf149f1>
> (9)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/PatternLayout.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4695c56eafc9da8cfb82c89ad63e9522902bd94c9aba06d0c393405f65479b14>
> (8)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/Priority.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f6a8b53b07481c776050ba8fc9e2015c16ff3f479a3fe0c8a1b2c19a58303518>
> (10)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/PropertyConfigurator.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-607596a6cadd10faf2dbeefc4e03092264b8e0dbe23fb89ffa6505d644602c9d>
> (32)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/RenderedMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-bcf46bb82e70ef91ca69aaca2856819cf49e36063ca55a9c9ba830e9113c7cdb>
> (1)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/SimpleLayout.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-391621364102c02033b9932c88dee7ef660b27e0f1857ac5bba577c431b1ac35>
> (1)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/WriterAppender.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c3f68be1934991b7cd5cace64cb8061a381ca741b8c2437f2f287e1ddc2be954>
> (27)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/bridge/AppenderAdapter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ade5e4f325b014bd81d880cceafd83bec0cb1ae835d5b4a1e7dd43500e062a60>
> (9)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/bridge/AppenderWrapper.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-40172dc38db8310fbd541d4bfd5c5b204ea93f054aa01ad5d5dcfd330bb1184a>
> (6)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/bridge/LayoutAdapter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-afd33a683b5773b02fc5f3396a8d0424379482ae1a3b504ac0d84ea3a6659ee2>
> (6)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/bridge/LayoutWrapper.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-3526de738e7b3aa44ff7480e19d574253f6b111c5821a8566bac6ef94dd53fba>
> (2)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/bridge/LogEventAdapter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-432eafe703a78e25b851a88fada15a33191a419e2bf51be8945327266064610c>
> (21)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/bridge/LogEventWrapper.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-fa9f3b5c1395159be81323ee3b629262e2115db37c565383f464d2e439a4bff1>
> (27)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/bridge/RewritePolicyAdapter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-76c11f6b8e2351588cf4e595cba4c34adaf5b1efbb2a18a273e7cb30ea1e6753>
> (2)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/bridge/RewritePolicyWrapper.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-359e34ca2bf705e24ff120a9197726363d121e2901624894ec37692d39893deb>
> (6)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-a40499e562977cd0d7a1d418be6216b83e0f490c26cb6c42357017c3e5681155>
> (14)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/BuilderManager.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-938c0885df9437f3d6f5c490dca4d15d714bdc93d6f92834b718886592c24bb6>
> (31)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/builders/Holder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-85cf2296a5bbf75932164ce09bcdf5705f0cb4653055944f03fedfd3e6663048>
> (3)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/AppenderBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-19c853340b024e2e25ea5d88ab18bdf31986eac029c01f86651dcc4c9b00267f>
> (13)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/AsyncAppenderBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e4106e9d8aff7e02751a94f0cc939dd923279f4e555fb32da4f9802b13775936>
> (41)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/ConsoleAppenderBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-72b489b19f35b0e724b449e13b996c8f0756f4fedd3834e81e3ecea3d30edd71>
> (24)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/DailyRollingFileAppenderBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-9de4732245e31857376fe202fc0f264596fd78a890942717bc52e0f6ed516a62>
> (51)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/FileAppenderBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-efe21319780f90d23bbb323659b34d53cd2a4a14d607b62c8ea87a73654e6348>
> (45)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/NullAppenderBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-aedaf19efc18c6fdd9e9ba18649ce4a0de352e5797e920134a19cce55386a4c7>
> (17)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/RewriteAppenderBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-6f21d2e134a82bb24408c9ac0507a33771cfd76883f35b60d81dcadc3b75108d>
> (39)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/RollingFileAppenderBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-0f088a981c9e1196656422ecf62428c0d9cd07adc501515177f9569bf12136e0>
> (51)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/SyslogAppenderBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-3276a764a345164def28901ad8a0c5bf7df6695cb51daed4940bf22e58605bf8>
> (32)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/filter/DenyAllFilterBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e0ffd4988985ec1d312c7db563ed6329b9e0f950dcd8932fe0e185deb17b5815>
> (4)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/filter/FilterBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c31cc581a3562bc4ab83a027abb66515ed903f9cdd426c3a075312febe7329b7>
> (1)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/filter/LevelMatchFilterBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f09f30a1ac51b059e4eff0642800a102641b171fe4ed6ee4015094d0446b9442>
> (4)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/filter/LevelRangeFilterBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-8dda6915658b8ebcd28965ea4ee3136563526a1c6b30c8ad83742f053758a854>
> (8)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/filter/StringMatchFilterBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c4bae334512652a1e66640fc8c266aeac8f3b30c18e670095336bc92d1d6e985>
> (2)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/layout/HtmlLayoutBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4e1210ae401e3d3956e6c0136b9910fe47087cd7f672f3c33c3a5d7fc50ef65f>
> (5)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/layout/PatternLayoutBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-db0c8b2d189595d1ed828c4e0c23211dd487bae05ec4951382ad3ab10339cc42>
> (14)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/layout/SimpleLayoutBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-48d4a6f4540f31f9c668c1a0cfebed7ea298486fd858dffa66e32a77f8cc9e95>
> (4)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/layout/TTCCLayoutBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-429569bdd1de708d39363f646f71d873067af225cbd5f1fc022755ba767dca31>
> (25)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/builders/layout/XmlLayoutBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-5afb485416017365975828b0d02fe9dc3be11786b8c949065ea76d8ca79ad5ef>
> (5)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/component/helpers/Constants.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-b9b0775c3cb24a58441bb2302a87cd4337026a6eb74c6d20c434ab14fa8b7974>
> (65)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/config/InputStreamWrapper.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-46d55197ae24fbb7558af8aafe40cb6d46cd729d0f47f50c8848ee5c307cfdbc>
> (1)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1Configuration.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ec193b2c180765cad6f2d9ed209de31be7a415299489a0ee372b395961f96eeb>
> (4)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationConverter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-bb92c9355a47bfcf0a65f881c4947f796f9d7a2116603d0e404218b8e01e2aa3>
> (47)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-b7e74f6d225c77b9d0101702a9e573c61eada5cab7faf06951549e9064619a30>
> (4)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationParser.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-166679f926cfdd6b73e2a9cb1cdc66a395ab6d1434894159a1ceaa0d3ce81dc3>
> (218)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/config/PropertiesConfiguration.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-a48be8424064c021b6cac12cb24d9126ec405216d923cdaa8bfc0861293cafa7>
> (90)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/config/PropertiesConfigurationFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-3e5918f91bbe3c92f20f909f5201a6a6b3363fedcc323e17e47e3b5c30e79abd>
> (5)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/config/PropertySetter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-136d1094ca27ce5978c9377348e83947edb931f2cd8fceae7d441154bc2a0756>
> (25)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-53d37a7f90560f4decbfa7b5812ad780509ec0b1a22e8b88935a969d19d854f5>
> (7)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/helpers/Loader.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-0c811a466baf49036b9c27a11c1a563554beefae2c23545b94572839014407cc>
> (6)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/helpers/LogLog.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-fcaf6eabaa1a2332ff4fe628ceb274b5c2e0d4ee478daf92c6698ed5b393705a>
> (14)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/helpers/NullEnumeration.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-adee4dda5ba12a257810637cbcbfd8138bac1f1e54c264e65faac2f366171fab>
> (3)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/helpers/OptionConverter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-1427ed9a872b3b141f4f7bc70659a21f5600df2e99f2e5b1ce1ff524d7e373c0>
> (83)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/helpers/QuietWriter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-3f37521429b3bd97a15806af2e32fe554d945393657180e33a6c35a5551fc5eb>
> (13)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/layout/Log4j1XmlLayout.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-87d3ba807c23c36b0c5cec455ed8185e43bb11d02f02275835d5579d900a6503>
> (6)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/legacy/core/CategoryUtil.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-83f54b856bcd40bc929300ec16398ca6abbf47a800a3a5120115f7a60d827c16>
> (7)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/legacy/core/ContextUtil.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-d9f979eece544652a447fe662f14b4a1dadbf889715629fc37fefb82ea676526>
> (3)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/or/DefaultRenderer.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-bf027262ee965d987b1fb55462f4b9ec875fd14e08ed2090e27ee8ac3817c491>
> (9)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/or/ObjectRenderer.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-083c04274b6e2b738bf0b232320cc3119807c890f4640446b30e764d7059bc51>
> (2)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/or/RendererMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f8fac459d25a37901e63a2987bfd0689674b1b44928a2ef8000df8964b697bc4>
> (55)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/or/ThreadGroupRenderer.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-be18093040ce4801eac1dae772af1457e38a9347872e789a3420e401d80746c0>
> (7)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/or/jms/MessageRenderer.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-85c2518ee9450ca72e4c4b734f13d56a06d83d0aa110b80bcae237246f855948>
> (23)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/pattern/Log4j1MdcPatternConverter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-87bbe9350abe57591b50b73da8463d4965a45eccd90b68e4c001350a8ab76e61>
> (5)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/pattern/Log4j1NdcPatternConverter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-0101020769b6915a095121add71840aa952411b20e016c500be8292df237b438>
> (9)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/rewrite/MapRewritePolicy.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-2582f58392cfdf278eab1ef0336228b519af95121aa8d472c29372ff43fe581a>
> (17)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/rewrite/PropertyRewritePolicy.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-d28fda4e625c3534eaabbd094418e1f178a3286efbdbdd32ab23384b3975698d>
> (27)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/AppenderAttachable.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-7658391744458902fadc94b4cac3ff682950ede7dc444b5d820b26eb0247e53b>
> (6)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/Configurator.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-a256b32badfb72d4078951be93bbc07054ddb9f465298de18182e74ce1d84f44>
> (8)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/spi/ErrorCode.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c4949af03cb6e16f28d709f9cb0371fc8d29a59f733e114dff33f66c799269a8>
> (17)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/ErrorHandler.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-85c93ffc9dfaa75c1c18afe62264aa83ea3143541646da8a7206fa168b8e156c>
> (3)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/spi/Filter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4fcec37521a398d57f4974e360fa6df3329859be51f70f1a6cb895ded4d056b7>
> (4)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/HierarchyEventListener.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-b622d5f41d7f6a5021ac3e63642b9b4246e67ef110615bc0ee6fe150e22c493e>
> (8)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/LocationInfo.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-7ce8c019db7a81f7870c22a9fdded7684d649264a50f477620ade93e0e43db5e>
> (37)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/LoggerFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-47516763d83215f0aff991e9906aa3332d84b45a3a0a8494053c6fa5e27700aa>
> (1)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/LoggerRepository.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-734d7c5dab94ce2142a8e3434d6c8601a0978388fb922d8a272fadef1f4759c6>
> (1)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/LoggingEvent.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-eea5ac09ea676e6642937f1d3a441dbcfc0d0c43cb059e50a890c2d8761728bc>
> (72)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/spi/NOPLogger.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-14def253488cf0ec50a00f511c486d9d75637a80d70c8df2b9ea1698eb8344da>
> (2)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/NOPLoggerRepository.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-33c7ff84db3d13fdfd320b561e68e96455dcc1081a36e3bfd188ccd1b40ded80>
> (1)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/OptionHandler.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-3df83d24e71de60c520379584ebb8588370af39b8fca85c23d3c80ed05b7b1ca>
> (1)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/RendererSupport.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-57c35c911c3f3023fbd98bd8c39c5fb0af1edcd737f15562db8f1f8a93caae87>
> (5)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/RepositorySelector.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-8bc56b6909198a989adcfebd77166f875543ede2541449c91ea9a149e2130c12>
> (10)
> - *M* log4j-1.2-api/src/main/java/org/apache/log4j/spi/RootLogger.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-2b0d110959c993fb60915c800860ad0031b1cf72e364f07ccb5e21e261a6e794>
> (7)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-9a0b22dc029240a291518927f4a4dbe79af8f1712d39242b3e2c463f6732973e>
> (2)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableRenderer.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-bf2267ccf72873cfb2abb9399ac922e51f81da763552a6b03a42673745073898>
> (2)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableRendererSupport.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-eb19347076f31e5f00e5be41b69135f6c05f5eb4b78a4d1282435da82c2746e5>
> (4)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/spi/TriggeringEventEvaluator.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e6241c141204d9fcfcac9d3f1013d783434c0b6668ed29a39c29ae18ebaccb96>
> (10)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/xml/DOMConfigurator.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-7f65f68ef30dffea7c36f618921e61c48718c8cfecd048072106e2a0bd9e3919>
> (43)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/xml/Log4jEntityResolver.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-5bacd86cb63c5023973e73844379cb56f4e8c59b122267c959fd461d8424cc30>
> (4)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/xml/UnrecognizedElementHandler.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-2e41c90020a19f976c97edf611f02f5b763c6172b3839067a7af450ac86cba30>
> (4)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/xml/XmlConfiguration.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-7b7229f693203b84d89cd3a4faba8c92738e1988b626d6d239f39547621a8eb3>
> (72)
> - *M*
> log4j-1.2-api/src/main/java/org/apache/log4j/xml/XmlConfigurationFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-19ad4d9fc8235ad4faa7d69767b689209d6423ade25cc1ee60b3c18b70589d80>
> (5)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/BasicConfigurationFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-6ad1670432a60d6a2570f170998cfdae8c2b4b2b11f2d0821ea7d2c6635c8bf3>
> (13)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/CallerInformationTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-8aa5044af7d4a3b9e0549cec59ca4091c19c3acc66b7d31f77c30fad2dfbe84d>
> (129)
> - *M* log4j-1.2-api/src/test/java/org/apache/log4j/CategoryTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e233fddc585ae871fb75e1beb02af705d79580a17c13b208b6a3ea6fd473661b>
> (30)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/CustomNoopAppender.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-7e01c7202c9fec579d552b0b65c4fa826475efbd22c9f7b268d783e8ef6a9c81>
> (1)
> - *M* log4j-1.2-api/src/test/java/org/apache/log4j/LevelTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ae019c24d6671de3cf89eb497967e1bf1881a3bc5fd2f522a6a4de6376e2b0c3>
> (21)
> - *M* log4j-1.2-api/src/test/java/org/apache/log4j/ListAppender.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-fb36c55f6b82f26fcd5c63b59a474799f5fe44276e691ed32c2c83840280cc95>
> (11)
> - *M* log4j-1.2-api/src/test/java/org/apache/log4j/LogManagerTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-b0afb4ccba7d3721c05d7f7d40f4e809de01f7f64a6ad3ba41b9a57c079aaf2b>
> (6)
> - *M* log4j-1.2-api/src/test/java/org/apache/log4j/LogWithMDCTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-31bb499418ab2a22b24f4ac1b23bbb01c4260ee1a87347ae66e1198698380361>
> (7)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/LogWithRouteTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-98b8d60aff7ecfd4e1bb5f4f84f76cd5c589d13a637753a5364be6c0db75021a>
> (9)
> - *M* log4j-1.2-api/src/test/java/org/apache/log4j/LoggerTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-0a1de6eb15686b7d60664201a337d51523441fadd642f6ab6a33fca00c036f42>
> (63)
> - *M* log4j-1.2-api/src/test/java/org/apache/log4j/LoggingTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-0acce444e5ea95095c97561c1079ef0fb56a9dc8fb9c6385ce504de7d1333d40>
> (85)
> - *M* log4j-1.2-api/src/test/java/org/apache/log4j/MDCTestCase.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ab5208d3fd38725795152036c7eeed104033e912bdf19a1616314dcd78c08cba>
> (1)
> - *M* log4j-1.2-api/src/test/java/org/apache/log4j/NDCTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-07dd0d8a4d3f0095689b3eff215f42c09295c56a1b89a5ae31c6ae0e6a0a6977>
> (3)
> - *M* log4j-1.2-api/src/test/java/org/apache/log4j/PriorityTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4b763b6de33f4b4ddf7f1f9bda45b880ccfe64ea51455f7f1a1a92c0b7afa203>
> (9)
> - *M* log4j-1.2-api/src/test/java/org/apache/log4j/VelocityTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e10d19fdc955cf561d4a19b46dc0b520397298814bf809b66ce5cd33cc15d892>
> (3)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/bridge/LogEventWrapperTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c31576dafaf5f3a2b035d209b24f50d77453af32ed5f6358119c4bb56f3088dd>
> (6)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/AbstractLog4j1ConfigurationConverterTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-6384e37223e8eaf3427532f569d3d0c7bd2e15a4a8217d130d4febd32b10bfab>
> (10)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/AsyncAppenderTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-a89ec4aac567c105af80078131af6e25797777b96fd056dbd199d3ee1e05007d>
> (3)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/AutoConfigTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-54835b1179a8bfb5d24590f77db27633a15a451a02df53d65d98fe982a6d4ce2>
> (2)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/Log4j1ConfigurationConverterHadoopTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c25aa12775b5dcf8b3114d32fc1117dd903ebc67dfe09bca0afeacc9507132ab>
> (2)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/Log4j1ConfigurationConverterSparkTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-1eb7738debbb73d951aa96815aafb4e2e13aa45e8989ade44d5da3a76d78b74f>
> (2)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/Log4j1ConfigurationFactoryTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-1dcab50e52862aaa1af6fab79b9544cb3d3178c86845f676ef23290008924803>
> (322)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/MapRewriteAppenderTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-fede969803de6144bc3c6005de63cc9f529053b5030230c9a386a734d12d0db9>
> (7)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/NeutralFilterFixture.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-968d5526ddd61049ba119bf0cfee74b8fb7093c5936b6dd668e473c5dff1bc53>
> (1)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesConfigurationFactoryTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ab996c08a036bd9d2d4fffcf27110e0640b6c820c4c1e6adc777603bed4c560e>
> (5)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesConfigurationTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4e90e6ad038c6f31f4fa99c5aad0e9855707cc51fd51a863df81c6ec8d9e5164>
> (8)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesReconfigurationTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-345636a7cf62a8a492d7f0008fc55acce299e55fbd8607a663639fc02cd24d25>
> (2)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesRollingWithPropertiesTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4fa4ff38aae0759c1c46b0a3d2214bddf0684710e15b06bc3865d689a87111c3>
> (2)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/RewriteAppenderTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-dafa2b0a222095b1630a4eadcc3d8b09e1a610541fb78a3e29dda322cd42fea4>
> (7)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/SyslogAppenderConfigurationTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c7775bd55ce0d898c00e454e5fed6bc3ff2a1acc9bcea128412edc869c3514aa>
> (1)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/SyslogAppenderTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-aa2bf26290ff62463416972f53af6a8d5945033510fa6a546e5ed9c0ac3d139c>
> (6)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/TestConfigurator.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-663c2238a2dfe309e2a88c4cb8240227cd5b75b662dda21dfe8c22bf356cd639>
> (2)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/XmlConfigurationFactoryTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e419b789027620b1c6a6ddb87b9ea4e062684a47ed308d37c2017283dd1c244b>
> (6)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/XmlConfigurationTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-cf2c1c8a3b65bf92c2ba241d124306b77250e7137a30ed19c095174e9b51a9fe>
> (2)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/config/XmlReconfigurationTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-53134374625c9a91d1a453aaa0389f7b89f1f3570648376a85ff00ac2b0a1846>
> (2)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/layout/Log4j1XmlLayoutTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-28471195db8b8e267d854bbec1cb967a06367c3597817e76e71fdcf29042a48e>
> (27)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/pattern/Log4j1MdcPatternConverterTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-24e77a145c65e93afd0563daa83d7e5d08c437605e1c26bbd86e2e9bcc34a581>
> (2)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/pattern/Log4j1NdcPatternConverterTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e2a6e5dab4860768f2b9ca9911152fbe62cb80e17bc4dc04cd93c0074bebf429>
> (6)
> - *M*
> log4j-1.2-api/src/test/java/org/apache/log4j/util/SerializationTestHelper.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-d7c6d47fab8fea97ba4d483efef0518bde7e816d7e6da1268f467e85a72cb06c>
> (18)
> - *M* log4j-api-java9/src/main/java/org/apache/logging/log4j/Dummy.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-0a04e395184793c6e6b88364f5a3b105d3ffd3b46871588d5b15919360c9d461>
> (3)
> - *M*
> log4j-api-java9/src/main/java/org/apache/logging/log4j/log4j/util/PropertySource.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-1203192c705297d69d3b52c2326ccdc7c79f103beda227043b1f76c8cd69582b>
> (3)
> - *M*
> log4j-api-java9/src/main/java/org/apache/logging/log4j/message/Dummy.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-291760ced5895bbfca8519c44cb3572809a64401ea31f7e24a10d57120a2e5af>
> (3)
> - *M*
> log4j-api-java9/src/main/java/org/apache/logging/log4j/message/ThreadDumpMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ce8256845f2ed38075f1b7ed896cf94ba2437ec432c01ce449174f840f801363>
> (4)
> - *M*
> log4j-api-java9/src/main/java/org/apache/logging/log4j/simple/Dummy.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-8bce8e3b50dcff3d1b7a9a597ac1e3ddb398cf608a9ae188bd1c5c8eeacf1c11>
> (3)
> - *M*
> log4j-api-java9/src/main/java/org/apache/logging/log4j/spi/Provider.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-2c3271fd57632a054d595ea04dd916e6fbfb51f9aa731837a6a6d2a1e99692e9>
> (3)
> - *M*
> log4j-api-java9/src/main/java/org/apache/logging/log4j/status/Dummy.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-95a0163cff53d59bbc6e66007d6f2477d3fc3f59fb1980475702763da623c369>
> (3)
> - *M*
> log4j-api-java9/src/main/java/org/apache/logging/log4j/util/Base64Util.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-717e4bffce8310f396c30676bdffac983ba9260e044287d02cf8f205c78dc290>
> (4)
> - *M*
> log4j-api-java9/src/main/java/org/apache/logging/log4j/util/ProcessIdUtil.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-7909acfe6a98902762544f1302204fcc83eb9598e40ed1fe4e273277cbf0fcd6>
> (2)
> - *M*
> log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-0180c2c2f92ef25e2251de99f0b3c607b2e138ec493fc5d40a44c6fd0f6e9655>
> (64)
> - *M*
> log4j-api-java9/src/main/java/org/apache/logging/log4j/util/internal/DefaultObjectInputFilter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-3084b593c37f8db873226b9ce5ed47e2834ec05abc00af5482ea3ec7fa6fb86f>
> (12)
> - *M* log4j-api-java9/src/test/java/module-info.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-0862a742a73dd4c4966d451a6d260201d6a1aec344224a51f7b99548859e7cfc>
> (1)
> - *M*
> log4j-api-java9/src/test/java/org/apache/logging/log4j/util/java9/ProcessIdUtilTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-56a0d114734498f402f7bd64aa965d66848ef354775da746aacc430d3df96d25>
> (4)
> - *M*
> log4j-api-java9/src/test/java/org/apache/logging/log4j/util/java9/StackLocatorTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e3668b517e3b0c47a9aa4785082b9a6d014582e6fe5bb6db174ddeca5c8ce038>
> (10)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/CloseableThreadContext.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-d3154189ad14a9d536a92bc81c44d80a2eceaaefb3631b145d7361e72c781fee>
> (10)
> - *M* log4j-api/src/main/java/org/apache/logging/log4j/Level.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c3b6ef0f40a2d67436a716e1142a6e6df061132f8022d4757dbcf93ce8e5b5a7>
> (1)
> - *M* log4j-api/src/main/java/org/apache/logging/log4j/LogBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-eed66d6b0552b766125908612ae7120390495cabe1abc07098e8f695ca63408e>
> (80)
> - *M* log4j-api/src/main/java/org/apache/logging/log4j/LogManager.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-bb74da3062fc183b1de5186a120db3f28ad336119a5497ee8ea8f8cf35254722>
> (81)
> - *M* log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-00f055d45398acda2497e3e86d90d716a19102a66080f5a34753e93f473be1b3>
> (523)
> - *M* log4j-api/src/main/java/org/apache/logging/log4j/Marker.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ae489ec6efd874246949552500b5718143d15394845946bb43896074db1b74cd>
> (18)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-330cfe99a3a963a7dd9dd96c891bf869554794fe65cb03f1f9fa7f3f57186525>
> (5)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/ThreadContext.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-d3559eaf26d80ab040462912edffb0394554fee4e2b01ccd1bb8bcd8a823f801>
> (7)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/internal/DefaultLogBuilder.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-77b0f07296f1f64835ee4c5c0bdb7f5846982420e9abe41237b4ce30daea2103>
> (40)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/AbstractMessageFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f1aeef7f29d8a5839b33b799d0c67b9fd856d8a1255fdf76d99552203c8410aa>
> (84)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/AsynchronouslyFormattable.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-54c7ed2400b294e79b01a39cee516e4918972075dc2e5ae4b9b46bf0a37e59f3>
> (5)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/Clearable.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-b08cc97c61281fcc8ac134ea7b02d0dc8a5d1259402f9660176eae223e7f19ba>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/DefaultFlowMessageFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ee0be32542cd2024376859ab87e3932ca68665a2d3c7d8d8cca7ff45e3038ad1>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/EntryMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4985144d5bf4fb3822ac4423e7a7c4884395ee75626ae069ba145b01241b6822>
> (52)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ExitMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-6858e39ce1216b0f05c04963219bd3d8d307cc836fdb1529f15041409c66e907>
> (52)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/FlowMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-bff166eded0b752c99dd57de371bd474c31ea6c32235bf8291600c1435078306>
> (78)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/FlowMessageFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-811ccb1e744fffa2f17e11d0cb375e5023185b3f99375e3bf5e41c38974ae349>
> (2)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ff31f618923906ed43fd9dba9631ad5201d6b5216bad5fdd7c090496f115ef9e>
> (15)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessageFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f1dd70e0101993cf8326b80c39fdd546187838862e4147baaf5e49ea10d8b77b>
> (68)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/LocalizedMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ebbf6a1069c458ec0ecfe5fcda87aef148d0dd7f38adf30567cda189ed1cdbe1>
> (25)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/LocalizedMessageFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f2a005e4d3efefeed92f2e40dac54959fc41e15ddc56b60dadba2ddbc63e0f62>
> (9)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/MapMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f03ffe9ceefd37c87fd118ce591bd8ad288e43b08cd663dde14441f4e7c117ef>
> (56)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/MapMessageJsonFormatter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-41b4f4929a0b4f6f96d391d18bc348177af5f6ce621545f8b4f6820fbfe7c1d1>
> (68)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/MessageCollectionMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-de2bbd656ec0075a58c5500befa1287f5de381cac733128bf83a064fcfb6c981>
> (5)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/MessageFactory2.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4454da1790eed77d37fae3ca97171444bdc08b2b29f99c7dd7e356751ca758c5>
> (33)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/MessageFormatMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e0d58e36f44962de53b8bde20a1e15bfd4b809927e3d70d3192235fda21cdeb6>
> (6)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/MessageFormatMessageFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-69903b2f57f396cd92101ce643035babf9a29df186461e877f5c10b398adbc90>
> (68)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ObjectArrayMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4314bfa9e397f4a14e51bc838a0ca7036dd1128d11518a936c4f4d82eabea1c1>
> (267)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ObjectMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-2e9a1972b0feaeff88e958a7cab33a811403703479f7b2a3d8d2346ecddba879>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterConsumer.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4f3a209b2e0b83dfec2246a811098fb30d4c65ed3652e512fb0d8db5931d54c0>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-2f7e4f9a5926fee0cf2f5912504cae86689e3b80d454e1ab28d9ae91e4aef024>
> (63)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterVisitable.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-0f0829b7729d884ac1dcb946d688eacb35466551e492a105e127a02ef21c6979>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-5981cd64704964fa0544c8056fa1d657e09cc1840970cccc8c90db9f47f5a262>
> (11)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMessageFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-8b82f4ad94d3c7f7b9f0cc7761c872cce4e09b48192d4129fefc82e06602e472>
> (68)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedNoReferenceMessageFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-eb3948520912088b8eab4a2e7eb8bf369394f0d53b8a5fc46e0495db782f5669>
> (3)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableMessageFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-7cd790ea389b4e9dbffa3a13c050161cc7ae880be3e592dab223947a077205ae>
> (73)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-82329381aca2da2f88ee2b6b725dfe928c6e05a7fbdf34f47471995425f343cb>
> (76)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableSimpleMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e19540337ca9c64cd73c3ca5f13b7ab21b9ecd4167d0eae4ef081e253d47be66>
> (4)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/SimpleMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4c272381a9ec9cb03dc0baeda7102f13476e2a5ee4cbcc86aa0b8b05bfa3539c>
> (9)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/SimpleMessageFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-54d20ace67e8aff6bdb8b815b8e9aa31d39d3c22ec10621d7bc3fd94a6f917e4>
> (68)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/StringFormattedMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-005374aab06b5c5c45a14e4ce08621bffcdb0c72397b4ab11cbcc7259d193800>
> (24)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/StringFormatterMessageFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-2c48970c59ffdc2f2f94ac40add85d28713f22308dc7bcd946848052a16892f9>
> (67)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/StringMapMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-efbc445f237833d0b75f5049d8fa1002d8be06377b05afe63e96040d1e2f773f>
> (10)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataCollectionMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c714512c6e83d14a778d1def7f6ded024a2b5dfa4763fab8d1c0f34ac17d549b>
> (11)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataId.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f25d7f52d359d78e1473b50e728a16100e573a3e4a8dd943da3f205233365e13>
> (535)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-99b2d61a362737efc962a775e2d55f5f6c7a3087cdfb020e6d0de124e1a911c5>
> (38)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ThreadDumpMessage.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e6a3b6deabdb2f5be4388e261b8cc61a658954dea3f5cba13ab3a7e9d574720c>
> (20)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/message/ThreadInformation.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-1eec844cfc75f0fccf95bee276d82375a51de5abdf94fb4bb197ecb97582482b>
> (3)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/simple/SimpleLogger.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-5c26d5ffa44e42ebaa5a59c5a1ceb4f4b4048ac87362cc218fb6f24782184e46>
> (134)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/simple/SimpleLoggerContext.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-43b822c1655ead99490327b49eec94dc4e62f88c0db26f22f870b80f4d7ef753>
> (24)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/simple/SimpleLoggerContextFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-148b0850c8f0d6a7df80d1b0dc218f8ac324e598136135a5ec2fcb0e4d83a327>
> (14)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-38f034b86c1ff28d7806d0dafd41b1c1b350d4a8d20bf3f6d552aa6b80e65542>
> (1576)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLoggerAdapter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ebf00d63768726b41de8e1c68cae659096b4f94e9c951bbdf6854bddb0034e36>
> (25)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/CleanableThreadContextMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-380be5c6a87b79ca452d3264af705ef69f5d71a0e66b7ad4e843d2f6096265f4>
> (3)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/CopyOnWrite.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4cdd19533862d526aac08d1b0858070090322d607fe3c6c4a54014c7e06f7360>
> (3)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/CopyOnWriteSortedArrayThreadContextMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-d1daf65809186e378681b418221badb3bd3d132d1262f127614c1d5944ac4543>
> (7)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/DefaultThreadContextMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c5898066d6e89e00fcc8f8469d6bbb29058eb6fbb64138087f207882f9a41f9a>
> (19)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/DefaultThreadContextStack.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-3df0b33e2b12b5e040c3b2b4503ded9db8cf6c1a7f270db9a1ebe8a22cc37c36>
> (3)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedLogger.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-0b9c77b0e9ee519d301443c6e0c1e7e42987dbef2b8dc4e6cd7d4d869e4dce16>
> (166)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedLoggerWrapper.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-bb94a45df62edcfb2251f89c1843c71c140d963ecbc34f7ba553128e990b3874>
> (117)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/GarbageFreeSortedArrayThreadContextMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-168ebc14858769e31b6ffd39993cba81a31c0c026072a99032685cd72f7e9797>
> (11)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/LocationAwareLogger.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-4bf8335ac5313af0c7c773fa8ca6cd360ccac2d2a9a43b4690d746fd6d2a5676>
> (9)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerContextFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-1b9d06cc74bb3dd3da9044f186d39169c6c3f79ac85f2bb8dc0b0cd2ec6ec1b4>
> (9)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerContextKey.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-1d81b229a638913db6eeff52eb357dd2e8d4b28def0789816c9cddf8b1133b12>
> (93)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerContextShutdownEnabled.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-02bf7c4c599e2112ca0c8ee42da301db1f70a69b14222f4b2b4548b1fb6aeb27>
> (2)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c3c4cb88304dd512f09da70c3fba2daa19fdcb2ca1bd2fccc4f9d917ac05c27f>
> (5)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/MessageFactory2Adapter.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-8742e73719a0d69560f094167da83bbfe26fbf56565a81052675e65d6ff21990>
> (69)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/MutableThreadContextStack.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-29b9eef8b4c065820536f81a138dcf768204553a3576b910dd4072a9e635066d>
> (2)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/NoOpThreadContextMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-939be75536e27c84d689940bfd80659431f96876fd4fca12243e8b309f4ea769>
> (9)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/ObjectThreadContextMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-d77b38d12ac8789c70386a066adb104401d0bd53a0106545b8369290ff089687>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-360fde5842f41926ba687e9af79bc80f2a437bb22baec95bd98eecd85866d3aa>
> (22)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/ReadOnlyThreadContextMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f30b2b7e1e4741aef92c31e4ffa529b9793a43f80ff05a0864a751099556250d>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/StandardLevel.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-17afa884d9afb4377385ba7e8260991d8696a547499ac8de3e1974a68724543d>
> (4)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/ThreadContextMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-37a5f0edc836115d8db61f2f29c6dbe6614008081687f1385e9ae0e8ce45518a>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/ThreadContextMap2.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ff58240148779482b263dafb9144842582475bb181349dbfcd36a7a001ff5c2d>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/spi/ThreadContextMapFactory.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-a1be34b0e046da0b02a2db3f4ea139d4f2f55fbf0489b71e6dc979f98465ea9e>
> (17)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/status/StatusConsoleListener.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e30201ff0d80d68f4e849ee1d5c120055d4d46fe285b877d25383359fa0866b4>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/status/StatusData.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-3a0dae5206782cfe3cb98a605ed5a66c75f1f16ed5fd947eb96db6535530ab21>
> (25)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/status/StatusListener.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-a093a0573dbce58cf329365ff0eee96f7bb3f1bd264fa8fcc3ce679db602cf13>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-7d0dc94da51804dbb43a9d81b65d142cf1f5e0cddb575ee77e1837ab06cc8441>
> (131)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/Activator.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-464b7b411f5782cbbed90095b78cb8b51fa4156c51d58ba3936ea0971bad4845>
> (38)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/Base64Util.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f033ebb4c1f0cdce51a868f8d8fb2330d89f7db8177d02213f67f17610c2468e>
> (6)
> - *M* log4j-api/src/main/java/org/apache/logging/log4j/util/Chars.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-d0a4de850fdb7fbebd7910089787b856a0b8025a858d1bfc13488bfbaa6cef66>
> (7)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/Constants.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-2f4ca7838284176bebb9e3e51da82f57b89da61d6580a36ff6397a73ab1c46d0>
> (14)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/EnglishEnums.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-3f55e96dcabac254ecf4b306fa33a0acbbfb2274871e00db8f404ed46f8471ba>
> (6)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/EnvironmentPropertySource.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-fc6aa091ac88424ffcd4cd81f492968420392ecdfd2e1e97587be1e621762070>
> (72)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/FilteredObjectInputStream.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-34061329f7e7c27847f8f3795aed0d9abd5c345a5941f500b4275b3c77613edd>
> (23)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/LambdaUtil.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-bb3de541dedefb168a2b6438b1a73af601db2cf1e51f63fd317c0badc87c8139>
> (4)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/LoaderUtil.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-2985773c7d115d08fe24f328ca8b7c11c220f0c47fd923decbb8b23d5f0da38f>
> (23)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/LowLevelLogUtil.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f6efca200a8aadcbe5d42a25fc7d4b6d20cd96f049775f0a5b3082319e50f617>
> (5)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/MultiFormatStringBuilderFormattable.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-e02d0a4b7a4f7f0eeadf5fb271dcdd070816dd438984df8e7d3f8be2d6cd5459>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/PrivateSecurityManagerStackTraceUtil.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-6d946950164eda17876fa3995beac83b5a26fffd764db4661e546db54fac9ee4>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/ProcessIdUtil.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-16f92b3725e6d19439da4474cbf069b3861ed445821a66c7e1b6b424d88d9912>
> (5)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-76c7467e6213a4df2a9aaa05aa0d822f6cef6506a5bbbfdf447b2c1670c0bf4b>
> (41)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/PropertyFilePropertySource.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-2f5485dd2bedb83819c81e492993ec738f3c22916683f07ab8609750fe2e2d13>
> (1)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/PropertySource.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-5a22f67349087e1ce307462e7ff108cdfa5c31c5a0f077f2faa0e84c9ba48994>
> (14)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/ProviderUtil.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-3cf986b269294bb7a3781e957003dd6ffaf8780d77f626cc5342c29175969465>
> (25)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/ReadOnlyStringMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-98ab08e5dabb8096a7e7c2d59f700f8177972a7f7fdaddda9a2144b9f039f688>
> (2)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/SortedArrayStringMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-98ade7200c7793e77d4ee2732864afdc250469b25fded714a82d5cf8ccba256a>
> (12)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/StackLocator.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-69876b095e76f9f89182a343bb8d40eef9ca6dcb18c980f2a5308ac98595643b>
> (11)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/StackLocatorUtil.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-34d2ee13e0c5799b45524477ded7e68162728d9ccef1b68f531d1fafadc31e4f>
> (4)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/StringBuilders.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-be84f196efba8433e2671be3e253ed5e945137f0e8663749a41b3de8df8fc78e>
> (31)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/StringMap.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-799b02394ec20d011381665791bbb78bb1abdf72b83ffbb1024ce32940beefb6>
> (2)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-9a543770e623f75d83a24646df4cc2836b59bd4dbddf3499447f663935edaf35>
> (21)
> - *M*
> log4j-api/src/main/java/org/apache/logging/log4j/util/SystemPropertiesPropertySource.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-cf51ad0c4c3a4379458359c322a459c46ab1fa6618ba9924529e68b4f38de77a>
> (73)
> - *M* log4j-api/src/main/java/org/apache/logging/log4j/util/Timer.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-a429d462ce8785e0558042ee4505402528cc8b21996fd03adfe545dff4b3ba64>
> (55)
> - *M* log4j-api/src/main/java/org/apache/logging/log4j/util/Unbox.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-7995be7b43202244983c9c1617d01f6515188303a854506ca01eb342ae8b022c>
> (15)
> - *M*
> log4j-api/src/test/java/org/apache/logging/log4j/AbstractLoggerTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-467bd39030ed6e9e45922073f38df0a3198dcc456d5cd82ce18c23c628d38f30>
> (304)
> - *M*
> log4j-api/src/test/java/org/apache/logging/log4j/AbstractSerializationTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-5b68cc1eb5e2ae77ff493485a5434ecca36b9405d88f281cd013f88b793757a8>
> (7)
> - *M*
> log4j-api/src/test/java/org/apache/logging/log4j/CloseableThreadContextTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-936c4c91dfc8387b9176b065e7761bbc0225b9f6c4eb3e63a0af9f912b617cdf>
> (36)
> - *M*
> log4j-api/src/test/java/org/apache/logging/log4j/EventLoggerTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-55b75950f59c46e7626ef029068ef7eeaa5af0a94a7ec42c38281d67ca2ce3ca>
> (13)
> - *M*
> log4j-api/src/test/java/org/apache/logging/log4j/LambdaLoggerTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f9bd939fd30d3e11d2b51ddb5feba7c6721de1ae66eb38e46bb86d9ffbcddf56>
> (133)
> - *M* log4j-api/src/test/java/org/apache/logging/log4j/LevelTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-d16e99d6f5ad7298f09cc790db1ba9cdd427002ec85d77b8cc0cb50781405abe>
> (5)
> - *M*
> log4j-api/src/test/java/org/apache/logging/log4j/LogManagerTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-c12b3284817b061d3fc98ec5df2074430cc3aeccece0505499bcf0e10cc390cc>
> (31)
> - *M*
> log4j-api/src/test/java/org/apache/logging/log4j/LoggerSupplierTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-bb13a4fb89fb501139b74aa39f1e70980426ca987da7aa2720609fb9e5bbc089>
> (385)
> - *M* log4j-api/src/test/java/org/apache/logging/log4j/LoggerTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-339e0662a9f5c9512baeb830028293890479d47d6a2734837f93c076b7ec76ae>
> (148)
> - *M* log4j-api/src/test/java/org/apache/logging/log4j/MarkerTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-f345b1379c3f9c39bf9d763f1b365adbe598420cbb9596056cfc92bcb383c2a9>
> (7)
> - *M*
> log4j-api/src/test/java/org/apache/logging/log4j/NoopThreadContextTest.java
> <https://github.com/apache/logging-log4j2/pull/697/files#diff-ba1f231b8cd448c0235f127c4bc2ebe2186fb690bcd63346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] carterkozak commented on pull request #697: [idea & example, request for input] Thoughts on using a code formatter?
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #697:
URL: https://github.com/apache/logging-log4j2/pull/697#issuecomment-1012183850
I'm not suggesting merging anything that formats the entire codebase in one go, this was meant as an example of the result before we commit to going down that path. Rollout is another beast, it can be done by applying constraints to files as they're modified rather than changing the world at once.
Committing to a particular formatter can be difficult because it front-loads the style bikeshedding which it eliminates later on. It may not be worthwhile, that's why I brought it up for discussion :-)
A lot of folks use the eclipse formatter, I've never found a configuration which works reasonably in all cases (lots of unnatural line breaks in unexpected places, but it may be better now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org