You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "aokolnychyi (via GitHub)" <gi...@apache.org> on 2023/05/09 00:08:43 UTC

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #7555: API, Core: Expose file and data sequence numbers through ContentFile

aokolnychyi commented on code in PR #7555:
URL: https://github.com/apache/iceberg/pull/7555#discussion_r1187999600


##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -113,6 +113,16 @@ default Integer sortOrderId() {
     return null;
   }
 
+  /** Returns the data sequence number of the snapshot in which the file should be applied. */
+  default Long dataSequenceNumber() {

Review Comment:
   We actually deprecated and removed `sequenceNumber` in `ManifestEntry` cause it was not clear what it represents. I'd be inclined to match what we currently have in `ManifestEntry`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org