You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/02/24 02:49:13 UTC

[GitHub] [incubator-brpc] zyearn opened a new issue #1045: The issues need to be resolved before next release

zyearn opened a new issue #1045: The issues need to be resolved before next release
URL: https://github.com/apache/incubator-brpc/issues/1045
 
 
   1. frame graph category b problem
   
   Let user install the frame graph dependency, and set the env variable to the location of script.
   brpc docs should also be updated correspondingly to guide user.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] WillemJiang commented on issue #1045: The issues need to be resolved before next release

Posted by GitBox <gi...@apache.org>.
WillemJiang commented on issue #1045: The issues need to be resolved before next release
URL: https://github.com/apache/incubator-brpc/issues/1045#issuecomment-591856739
 
 
   If we don't change the frame graph code , we don't need to ship the code in the source release. 
   We can provide a script to download the frame graph dependency before build the source.
   In this way we can make sure our source release is follow the Apache release rule.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] zyearn commented on issue #1045: The issues need to be resolved before next release

Posted by GitBox <gi...@apache.org>.
zyearn commented on issue #1045: The issues need to be resolved before next release
URL: https://github.com/apache/incubator-brpc/issues/1045#issuecomment-591917871
 
 
   It's a good advice. We can mention in the doc that only users who need frame graph feature should download and install it. Otherwise just build the source.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] tanzhongyibidu commented on issue #1045: The issues need to be resolved before next release

Posted by GitBox <gi...@apache.org>.
tanzhongyibidu commented on issue #1045: The issues need to be resolved before next release
URL: https://github.com/apache/incubator-brpc/issues/1045#issuecomment-591893524
 
 
   IMO that's a good suggestion, 
   jiashun,  how do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org