Re: [PR] [SPARK-53598][SQL] Check numParts field for Hive tables before reading schema [spark]

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #52355:
URL: https://github.com/apache/spark/pull/52355#discussion_r2354402938


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala:
##########
@@ -763,11 +763,17 @@ object CatalogTable {
     }
   }
 
-  def readLargeTableProp(props: Map[String, String], key: String): Option[String] = {
+  def readLargeTableProp(
+      props: Map[String, String],
+      key: String,
+      failIfNumPartsMissing: Boolean = true): Option[String] = {

Review Comment:
   when it's needed to be true? I think it's fine to always be more lenient, as the consequence is simply doing a schema inference, which is better than failing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org