You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/05/05 17:14:28 UTC
[GitHub] [accumulo] keith-turner opened a new pull request, #3382: WIP initial stab at moving splits to the manager
keith-turner opened a new pull request, #3382:
URL: https://github.com/apache/accumulo/pull/3382
I am still working on this, but the I think the bones are there for splitting in the manager. I hope to post a non draft PR in the next day or two for this. I still have a lot of little odds and ends to finish up and go back over the code and clean up things. Just posting a draft PR in case anyone wants to look at the bones in the following locations.
```
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/split/*
server/manager/src/main/java/org/apache/accumulo/manager/split/*
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #3382: WIP initial stab at moving splits to the manager
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #3382:
URL: https://github.com/apache/accumulo/pull/3382#discussion_r1187377994
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1273,6 +1323,10 @@ boolean canSuspendTablets() {
throw new IllegalStateException("Exception updating manager lock", e);
}
+ // TODO shut this down later? Is this the correct place to start this?
+ this.splitter = new Splitter(context, DataLevel.USER, this);
Review Comment:
Is there a reason not to make this part of the TabletGroupWatcher?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #3382: Moved automatic splits to the manager
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #3382:
URL: https://github.com/apache/accumulo/pull/3382#issuecomment-1553590826
There were many TODOs in this code. Opened follow on issues for them #3406,#3407,#3408,#3410,#3411,#3412, and #3413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner merged pull request #3382: Moved automatic splits to the manager
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #3382:
URL: https://github.com/apache/accumulo/pull/3382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on a diff in pull request #3382: WIP initial stab at moving splits to the manager
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #3382:
URL: https://github.com/apache/accumulo/pull/3382#discussion_r1187427945
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1273,6 +1323,10 @@ boolean canSuspendTablets() {
throw new IllegalStateException("Exception updating manager lock", e);
}
+ // TODO shut this down later? Is this the correct place to start this?
+ this.splitter = new Splitter(context, DataLevel.USER, this);
Review Comment:
Not that I know of, I did not start there because I was unsure if that was the best path and I wanted to get some basic functionality working. I think that would be a good follow on issue to explore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org