You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@newton.ch.collab.net> on 2002/08/22 18:43:06 UTC

Re: svn commit: rev 3014 - trunk/subversion/libsvn_subr

Philip Martin <ph...@codematters.co.uk> writes:
> > +  apr_err = apr_file_close (format_file);
> > +  if (apr_err)
> > +    return svn_error_createf (apr_err, 0, 0, pool,
> > +                              "closing `%s'", format_file);
> 
> ../svn/subversion/libsvn_subr/io.c: In function `svn_io_read_version_file':
> ../svn/subversion/libsvn_subr/io.c:1901: warning: char format, apr_file_t arg (arg 6)

Bizarre -- why didn't I get that error??  It not only built, it fixed
the bug I was seeing.  Sigh.  Taking a look, thanks!

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 3014 - trunk/subversion/libsvn_subr

Posted by Philip Martin <ph...@codematters.co.uk>.
Branko Čibej <br...@xbc.nu> writes:

> >>>>+  apr_err = apr_file_close (format_file);
> >>>>+  if (apr_err)
> >>>>+    return svn_error_createf (apr_err, 0, 0, pool,
> >>>>+                              "closing `%s'", format_file);
> >>>>
> 
> >>>../svn/subversion/libsvn_subr/io.c: In function `svn_io_read_version_file':
> >>>../svn/subversion/libsvn_subr/io.c:1901: warning: char format, apr_file_t arg (arg 6)
> >>>
> 
> >>Bizarre -- why didn't I get that error??
> >>
> 
> >
> >You are not using gcc 3.1.1 :)
> >
> Huh? -Wformat has been in gcc since forever.

Interesting.  I just tried gcc versions 3.3, 3.1.1, 3.0.4 and 2.95.4.
Both 3.3 and 3.1.1 produce the warning (using -Wall), both 3.0.4 and
2.95.4 are silent (even with -Wformat).  So, like Subversion, gcc is
getting better!

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 3014 - trunk/subversion/libsvn_subr

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Branko Čibej <br...@xbc.nu> writes:
> >You are not using gcc 3.1.1 :)
>
> Huh? -Wformat has been in gcc since forever.

Yeah, I usually get those warnings too.  Don't know why I didn't get
one this time, unless I did and somehow lost it in the noise.

Thank goodness for Old Hundred Eyes :-).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 3014 - trunk/subversion/libsvn_subr

Posted by Branko Čibej <br...@xbc.nu>.
Philip Martin wrote:

>Karl Fogel <kf...@newton.ch.collab.net> writes:
>
>  
>
>>Philip Martin <ph...@codematters.co.uk> writes:
>>    
>>
>>>>+  apr_err = apr_file_close (format_file);
>>>>+  if (apr_err)
>>>>+    return svn_error_createf (apr_err, 0, 0, pool,
>>>>+                              "closing `%s'", format_file);
>>>>        
>>>>
>>>../svn/subversion/libsvn_subr/io.c: In function `svn_io_read_version_file':
>>>../svn/subversion/libsvn_subr/io.c:1901: warning: char format, apr_file_t arg (arg 6)
>>>      
>>>
>>Bizarre -- why didn't I get that error??
>>    
>>
>
>You are not using gcc 3.1.1 :)
>
Huh? -Wformat has been in gcc since forever.

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 3014 - trunk/subversion/libsvn_subr

Posted by Philip Martin <ph...@codematters.co.uk>.
Karl Fogel <kf...@newton.ch.collab.net> writes:

> Philip Martin <ph...@codematters.co.uk> writes:
> > > +  apr_err = apr_file_close (format_file);
> > > +  if (apr_err)
> > > +    return svn_error_createf (apr_err, 0, 0, pool,
> > > +                              "closing `%s'", format_file);
> > 
> > ../svn/subversion/libsvn_subr/io.c: In function `svn_io_read_version_file':
> > ../svn/subversion/libsvn_subr/io.c:1901: warning: char format, apr_file_t arg (arg 6)
> 
> Bizarre -- why didn't I get that error??

You are not using gcc 3.1.1 :)

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 3014 - trunk/subversion/libsvn_subr

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Karl Fogel <kf...@newton.ch.collab.net> writes:
> > ../svn/subversion/libsvn_subr/io.c: In function `svn_io_read_version_file':
> > ../svn/subversion/libsvn_subr/io.c:1901: warning: char format, apr_file_t arg (arg 6)
> 
> Bizarre -- why didn't I get that error??  It not only built, it fixed
> the bug I was seeing.  Sigh.  Taking a look, thanks!

Not confusing now, it turned out to be the other mismatch.  Fixed.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org