You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/14 21:38:22 UTC

[GitHub] [superset] geido commented on pull request #12502: fix: Jumpiness of datasource modal

geido commented on pull request #12502:
URL: https://github.com/apache/superset/pull/12502#issuecomment-760492459


   I think I am now seeing the issue. I am not confident anymore to apply the fix globally to the modals as we might end up in scenarios like the one depicted here https://github.com/apache/superset/pull/11770#issuecomment-741438519. I am only including the fix to the jumpiness in this PR as of now. 
   
   For the "Save" modal issue specifically, this #12522 should be preferred even though it is not a global fix. 
   
   As for the sticky components described in #12488  and #12503 I'll be providing them in a separate PR asap.
   
   @junlincc @ktmud 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org