[GitHub] spark pull request #18425: [SPARK-21217][SQL] Support ColumnVector.Array.to<...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18425#discussion_r125869562
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java ---
    @@ -80,6 +80,14 @@ public static ColumnVector allocate(int capacity, DataType type, MemoryMode mode
         public int length;
         public int offset;
     
    +    // reused buffer to return a primitive array
    --- End diff --
    
    I'm not sure if we need this buffer. `UnsafeArrayData.toXXXArray` doesn't use a buffer, and it seems safer to always return a new array.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org