You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bugraoz93 (via GitHub)" <gi...@apache.org> on 2025/11/09 16:47:30 UTC
[I] Add all commands to airflowctl integration tests [airflow]
bugraoz93 opened a new issue, #58106:
URL: https://github.com/apache/airflow/issues/58106
### Description
Every command is executed during integration tests with all parameters, covering all possible boolean combinations.
**Bonus:** Automating this via generating a certain type of dummy values and running those commands using a parser. This could eliminate the pre-commit need.
### Use case/motivation
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [x] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add all commands to airflowctl integration tests [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on issue #58106:
URL: https://github.com/apache/airflow/issues/58106#issuecomment-3568412025
Hey @steveahnahn for sure. Assigning the issue to you. For sure, it should be sufficient without a generator. Indeed, it could go easily out of hand. Thanks for picking it up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add all commands to airflowctl integration tests [airflow]
Posted by "steveahnahn (via GitHub)" <gi...@apache.org>.
steveahnahn commented on issue #58106:
URL: https://github.com/apache/airflow/issues/58106#issuecomment-3568394993
Hey @bugraoz93, may I be assigned this task? I took a look at implementing this and wanted to run an approach by you. I analyzed the current coverage and found there are 33 missing tests spread across 8 command groups. After thinking through whether we could auto-generate these tests by parsing the CLI cmd definitions, I believe the pragmatic approach of manually adding all the missing tests and maintaining via pre-commit would be sufficient. A generator may be difficult to validate and maintain confidence in its extensibility for future commands.
Does this approach sound reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add all commands to airflowctl integration tests [airflow]
Posted by "steveahnahn (via GitHub)" <gi...@apache.org>.
steveahnahn commented on issue #58106:
URL: https://github.com/apache/airflow/issues/58106#issuecomment-3578361915
Opened a PR to take care of part 1: https://github.com/apache/airflow/pull/58701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add all commands to airflowctl integration tests [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 closed issue #58106: Add all commands to airflowctl integration tests
URL: https://github.com/apache/airflow/issues/58106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org