You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/19 08:39:24 UTC

[GitHub] [incubator-doris] yangzhg commented on pull request #4366: Optimise coding bit operation in BE

yangzhg commented on pull request #4366:
URL: https://github.com/apache/incubator-doris/pull/4366#issuecomment-675954087


   @imay From the point of view of implementation, our implementation should be copied from leveldb, but leveldb has removed some  unnecessary bit operation in this pr https://github.com/google/leveldb/commit/cf1b5f473259e46c667f3fb5a28bcd884ee3a102#diff-0f30ecb01c7888631c52ec595204f7f0 , so I think we can also change to the same implementation as level db, although this change improves performance not particularly big 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org