You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/12 21:10:16 UTC

[GitHub] [superset] eschutho commented on a change in pull request #16241: fix: validate_parameters and query

eschutho commented on a change in pull request #16241:
URL: https://github.com/apache/superset/pull/16241#discussion_r688086977



##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -319,6 +320,18 @@ function dbReducer(
         [action.payload.name]: action.payload.json,
       };
     case ActionType.textChange:
+      if (action.payload.name === 'query_input') {

Review comment:
       in this case, because it has a different return value, should we just make a different action name?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org