You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by is...@cocoondev.org on 2004/07/22 10:06:49 UTC
[issues] Closed: (FOR-174) Have @class attribute in DTD for every tag
Message:
The following issue has been closed.
Resolver: David Crossley
Date: Thu, 22 Jul 2004 10:06 AM
Many thanks to Rick. Again applying your patches is joyful. Thanks for the comprehensive list of changes. That really helps the job of the committer.
Is there anything else that we should notify in the status.xml/changes?
---------------------------------------------------------------------
View the issue:
http://issues.cocoondev.org/jira//secure/ViewIssue.jspa?key=FOR-174
Here is an overview of the issue:
---------------------------------------------------------------------
Key: FOR-174
Summary: Have @class attribute in DTD for every tag
Type: Improvement
Status: Closed
Priority: Critical
Resolution: FIXED
Project: Forrest
Component: Core operations
Fix For: 0.6
Versions:
HEAD
Assignee: David Crossley
Reporter: Nicola Ken Barozzi
Created: Thu, 10 Jun 2004 11:10 AM
Updated: Thu, 22 Jul 2004 10:06 AM
Description:
Add @class attribute to all tags so that the extra-css section in the skinconf can be put to good use.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.cocoondev.org/jira//Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
Re: [patch] + Notes (was: Re: [issues] Closed: (FOR-174) Have
@class attribute in DTD for every tag)
Posted by David Crossley <cr...@apache.org>.
Rick Tessner wrote:
>
> Below are the notes on the changes between V1.2 & V1.3, V2.0a & V2.0 and
> finally between V1.3 & V2.0.
>
> In addition, I found a problem with the v20/document-v20.mod. Patch
> attached. The problem was that I'd inadvertently added back the link,
> jump and fork elements in addition to the <a> element in v2.0. This
> patch keeps the <a> but removes the <link>, <jump> and <fork> elements.
Thanks. Patch applied. Added the notes to the "upgrading_06" doc.
--
David Crossley
[patch] + Notes (was: Re: [issues] Closed: (FOR-174) Have @class
attribute in DTD for every tag)
Posted by Rick Tessner <ri...@onnadayr.ca>.
On Thu, 2004-07-22 at 19:23, David Crossley wrote:
> Rick Tessner wrote:
> > If you want some notes on the lack of forward-compat of v1.2/1.3 to
> > v2.0, let me know and I'll put something together.
>
> Yes please, some dot points would be sufficient.
> Perhaps we would add them to the upgrading_06 docs.
Below are the notes on the changes between V1.2 & V1.3, V2.0a & V2.0 and
finally between V1.3 & V2.0.
In addition, I found a problem with the v20/document-v20.mod. Patch
attached. The problem was that I'd inadvertently added back the link,
jump and fork elements in addition to the <a> element in v2.0. This
patch keeps the <a> but removes the <link>, <jump> and <fork> elements.
Changes from V1.2 to V1.3
=========================
document - Addition of class attribute all elements
faq - Addition of class attribute all elements
changes - Addition of class attribute all elements
howto - Addition of class attribute all elements
todo - Addition of class attribute all elements
Changes from V2.0a to V2.0
==========================
document - Addition of class attribute, all elements
- Addition of label attribute to note and
warning elements (consistent with v1.2/1.3)
faq - Class attribute, all elements
changes - New DTD
howto - New DTD
todo - New DTD
Changes from V1.3 to V2.0
=========================
document - Renamed <link> to <a>
- Removed <fork> and <jump>. If desired,
that functionality can be handled via
the use of the class attribute on <a>.
faq - Renamed <part> to <faqsection>
- @title attribute on <faqs> is now a nested
<title> element
- Same changes as in document between 1.3 and 2.0
changes - Same changes as in document between 1.3 and 2.0
howto - Same changes as in document between 1.3 and 2.0
todo - Same changes as in document between 1.3 and 2.0
--
Rick Tessner <ri...@onnadayr.ca>
Re: [issues] Closed: (FOR-174) Have @class attribute in DTD for
every tag
Posted by David Crossley <cr...@apache.org>.
Rick Tessner wrote:
> David Crossley wrote:
> > Is there anything else that we should notify in the status.xml/changes?
>
> The only things I can think of are:
>
> * V1.2 docs will work fine as V1.3 (forward compatibility).
> * V1.2/1.3 are not forward-compatible as V2.0.
Done in status.xml/changes and in upgrading_06 doc.
> If you want some notes on the lack of forward-compat of v1.2/1.3 to
> v2.0, let me know and I'll put something together.
Yes please, some dot points would be sufficient.
Perhaps we would add them to the upgrading_06 docs.
> I did notice though that two of the new files were not added:
>
> * src/core/context/resources/stylesheets/docv20todocv13.xsl
> * src/core/context/resources/stylesheets/faqv20tofaqv13.xsl
>
> Hopefully, that can be corrected. Thanks for applying the patch. :)
Done. Sooner or later i would have seen them sitting here.
I missed them with 'svn status' because i have some of my
unfinished work too.
--
David Crossley
Re: [issues] Closed: (FOR-174) Have @class attribute in DTD for
every tag
Posted by Rick Tessner <ri...@onnadayr.ca>.
On Thu, 2004-07-22 at 01:06, issues@cocoondev.org wrote:
> Message:
>
> The following issue has been closed.
>
> Resolver: David Crossley
> Date: Thu, 22 Jul 2004 10:06 AM
>
> Many thanks to Rick. Again applying your patches is joyful. Thanks for
> the comprehensive list of changes. That really helps the job of the
> committer.
Thanks. :)
> Is there anything else that we should notify in the status.xml/changes?
The only things I can think of are:
* V1.2 docs will work fine as V1.3 (forward compatibility).
* V1.2/1.3 are not forward-compatible as V2.0.
If you want some notes on the lack of forward-compat of v1.2/1.3 to
v2.0, let me know and I'll put something together.
I did notice though that two of the new files were not added:
* src/core/context/resources/stylesheets/docv20todocv13.xsl
* src/core/context/resources/stylesheets/faqv20tofaqv13.xsl
Hopefully, that can be corrected. Thanks for applying the patch. :)
--
Rick Tessner <ri...@onnadayr.ca>