You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "apurtell (via GitHub)" <gi...@apache.org> on 2026/05/01 23:48:46 UTC
[PR] PHOENIX-7830 De-flake MutableIndexFailureIT [phoenix]
apurtell opened a new pull request, #2447:
URL: https://github.com/apache/phoenix/pull/2447
`MutableIndexFailureIT` has two independent bugs that cause flaky and cascading test failures. First, the outer class declares its own static volatile `FAIL_WRITE` field that shadows `FailingRegionObserver.FAIL_WRITE`, so the finally block in `testIndexWriteFailure` resets the dead outer field and leaves `FailingRegionObserver.FAIL_WRITE` stuck at true when the test fails mid-way, breaking subsequent tests in the same fork. Second, `FailingRegionObserver.TOGGLE_FAIL_WRITE_FOR_RETRY` is not declared volatile even though it is written by app threads in `addRowsInTableDuringRetry` and read by region server handler threads in `preBatchMutate`, so the RS thread can observe a stale false, miss the retry toggle, and surface a `CommitException` that fails the assertion. The fix removes the shadowed outer `FAIL_WRITE` field, retargets the finally block to reset `FailingRegionObserver.FAIL_WRITE`, and marks `FailingRegionObserver.TOGGLE_FAIL_WRITE_FOR_RETRY` volatile to guarantee cross-thre
ad visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7830 De-flake MutableIndexFailureIT [phoenix]
Posted by "palashc (via GitHub)" <gi...@apache.org>.
palashc merged PR #2447:
URL: https://github.com/apache/phoenix/pull/2447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7830 De-flake MutableIndexFailureIT [phoenix]
Posted by "palashc (via GitHub)" <gi...@apache.org>.
palashc commented on PR #2447:
URL: https://github.com/apache/phoenix/pull/2447#issuecomment-4846296185
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2447/2/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org