You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/23 14:26:16 UTC
[GitHub] [incubator-doris] aihai opened a new pull request #7207: add BATCH DELETE support
aihai opened a new pull request #7207:
URL: https://github.com/apache/incubator-doris/pull/7207
## Proposed changes
add BATCH DELETE support
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [x] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7207: [feat](flink-connector) add BATCH DELETE support
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7207:
URL: https://github.com/apache/incubator-doris/pull/7207#discussion_r755235863
##########
File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisExecutionOptions.java
##########
@@ -105,6 +111,25 @@ public Builder setStreamLoadProp(Properties streamLoadProp) {
return this;
}
+ public Builder setJsonFormat() {
+ this.streamLoadProp.setProperty("format", "json");
+ this.streamLoadProp.setProperty("strip_outer_array", "true");
+ return this;
+ }
+
+ public Builder setMergeType(MergeType mergeType) {
+ this.streamLoadProp.setProperty("merge_type", mergeType.toString());
+ return this;
+ }
+
+ public Builder setDeleteLabel(String deleteLabel, String value) {
+ if (!MergeType.MERGE.toString().equals(this.streamLoadProp.getProperty("merge_type"))) {
+ return this;
+ }
+ this.streamLoadProp.setProperty("delete", deleteLabel + "=" + value);
Review comment:
the delete flag can be any expressions. For example:
`delete: ifnull(column1, 2) > 3`
So could you find a way to make it more flexible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] aihai closed pull request #7207: [feat](flink-connector) add BATCH DELETE support
Posted by GitBox <gi...@apache.org>.
aihai closed pull request #7207:
URL: https://github.com/apache/incubator-doris/pull/7207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7207: [feat](flink-connector) add BATCH DELETE support
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7207:
URL: https://github.com/apache/incubator-doris/pull/7207#discussion_r755659544
##########
File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisExecutionOptions.java
##########
@@ -105,6 +111,25 @@ public Builder setStreamLoadProp(Properties streamLoadProp) {
return this;
}
+ public Builder setJsonFormat() {
+ this.streamLoadProp.setProperty("format", "json");
+ this.streamLoadProp.setProperty("strip_outer_array", "true");
+ return this;
+ }
+
+ public Builder setMergeType(MergeType mergeType) {
+ this.streamLoadProp.setProperty("merge_type", mergeType.toString());
+ return this;
+ }
+
+ public Builder setDeleteLabel(String deleteLabel, String value) {
+ if (!MergeType.MERGE.toString().equals(this.streamLoadProp.getProperty("merge_type"))) {
+ return this;
+ }
+ this.streamLoadProp.setProperty("delete", deleteLabel + "=" + value);
Review comment:
looks good to me~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] aihai commented on a change in pull request #7207: [feat](flink-connector) add BATCH DELETE support
Posted by GitBox <gi...@apache.org>.
aihai commented on a change in pull request #7207:
URL: https://github.com/apache/incubator-doris/pull/7207#discussion_r755667293
##########
File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisExecutionOptions.java
##########
@@ -105,6 +111,25 @@ public Builder setStreamLoadProp(Properties streamLoadProp) {
return this;
}
+ public Builder setJsonFormat() {
+ this.streamLoadProp.setProperty("format", "json");
+ this.streamLoadProp.setProperty("strip_outer_array", "true");
+ return this;
+ }
+
+ public Builder setMergeType(MergeType mergeType) {
+ this.streamLoadProp.setProperty("merge_type", mergeType.toString());
+ return this;
+ }
+
+ public Builder setDeleteLabel(String deleteLabel, String value) {
+ if (!MergeType.MERGE.toString().equals(this.streamLoadProp.getProperty("merge_type"))) {
+ return this;
+ }
+ this.streamLoadProp.setProperty("delete", deleteLabel + "=" + value);
Review comment:
ok, i will open a new pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] aihai commented on a change in pull request #7207: [feat](flink-connector) add BATCH DELETE support
Posted by GitBox <gi...@apache.org>.
aihai commented on a change in pull request #7207:
URL: https://github.com/apache/incubator-doris/pull/7207#discussion_r755634973
##########
File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisExecutionOptions.java
##########
@@ -105,6 +111,25 @@ public Builder setStreamLoadProp(Properties streamLoadProp) {
return this;
}
+ public Builder setJsonFormat() {
+ this.streamLoadProp.setProperty("format", "json");
+ this.streamLoadProp.setProperty("strip_outer_array", "true");
+ return this;
+ }
+
+ public Builder setMergeType(MergeType mergeType) {
+ this.streamLoadProp.setProperty("merge_type", mergeType.toString());
+ return this;
+ }
+
+ public Builder setDeleteLabel(String deleteLabel, String value) {
+ if (!MergeType.MERGE.toString().equals(this.streamLoadProp.getProperty("merge_type"))) {
+ return this;
+ }
+ this.streamLoadProp.setProperty("delete", deleteLabel + "=" + value);
Review comment:
this.streamLoadProp.setProperty("delete", deleteflag);
How about it? If the delete flag can be any expressions, the user set the value by "deletaflag".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] aihai commented on a change in pull request #7207: [feat](flink-connector) add BATCH DELETE support
Posted by GitBox <gi...@apache.org>.
aihai commented on a change in pull request #7207:
URL: https://github.com/apache/incubator-doris/pull/7207#discussion_r755629441
##########
File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisExecutionOptions.java
##########
@@ -105,6 +111,25 @@ public Builder setStreamLoadProp(Properties streamLoadProp) {
return this;
}
+ public Builder setJsonFormat() {
+ this.streamLoadProp.setProperty("format", "json");
+ this.streamLoadProp.setProperty("strip_outer_array", "true");
+ return this;
+ }
+
+ public Builder setMergeType(MergeType mergeType) {
+ this.streamLoadProp.setProperty("merge_type", mergeType.toString());
+ return this;
+ }
+
+ public Builder setDeleteLabel(String deleteLabel, String value) {
+ if (!MergeType.MERGE.toString().equals(this.streamLoadProp.getProperty("merge_type"))) {
+ return this;
+ }
+ this.streamLoadProp.setProperty("delete", deleteLabel + "=" + value);
Review comment:
ok, I will check it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] aihai commented on a change in pull request #7207: [feat](flink-connector) add BATCH DELETE support
Posted by GitBox <gi...@apache.org>.
aihai commented on a change in pull request #7207:
URL: https://github.com/apache/incubator-doris/pull/7207#discussion_r755629441
##########
File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisExecutionOptions.java
##########
@@ -105,6 +111,25 @@ public Builder setStreamLoadProp(Properties streamLoadProp) {
return this;
}
+ public Builder setJsonFormat() {
+ this.streamLoadProp.setProperty("format", "json");
+ this.streamLoadProp.setProperty("strip_outer_array", "true");
+ return this;
+ }
+
+ public Builder setMergeType(MergeType mergeType) {
+ this.streamLoadProp.setProperty("merge_type", mergeType.toString());
+ return this;
+ }
+
+ public Builder setDeleteLabel(String deleteLabel, String value) {
+ if (!MergeType.MERGE.toString().equals(this.streamLoadProp.getProperty("merge_type"))) {
+ return this;
+ }
+ this.streamLoadProp.setProperty("delete", deleteLabel + "=" + value);
Review comment:
ok, I will check it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] aihai commented on a change in pull request #7207: [feat](flink-connector) add BATCH DELETE support
Posted by GitBox <gi...@apache.org>.
aihai commented on a change in pull request #7207:
URL: https://github.com/apache/incubator-doris/pull/7207#discussion_r755634973
##########
File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisExecutionOptions.java
##########
@@ -105,6 +111,25 @@ public Builder setStreamLoadProp(Properties streamLoadProp) {
return this;
}
+ public Builder setJsonFormat() {
+ this.streamLoadProp.setProperty("format", "json");
+ this.streamLoadProp.setProperty("strip_outer_array", "true");
+ return this;
+ }
+
+ public Builder setMergeType(MergeType mergeType) {
+ this.streamLoadProp.setProperty("merge_type", mergeType.toString());
+ return this;
+ }
+
+ public Builder setDeleteLabel(String deleteLabel, String value) {
+ if (!MergeType.MERGE.toString().equals(this.streamLoadProp.getProperty("merge_type"))) {
+ return this;
+ }
+ this.streamLoadProp.setProperty("delete", deleteLabel + "=" + value);
Review comment:
this.streamLoadProp.setProperty("delete", deleteflag);
How about it? If the delete flag can be any expressions, the user set the value by "deleteflag".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org