You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/19 02:18:16 UTC

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1903: fix: turn off online debug

liuxiran commented on a change in pull request #1903:
URL: https://github.com/apache/apisix-dashboard/pull/1903#discussion_r634867605



##########
File path: api/test/e2enew/route_online_debug/route_online_debug_suite_test.go
##########
@@ -28,7 +28,7 @@ import (
 
 func TestRoute(t *testing.T) {
 	gomega.RegisterFailHandler(ginkgo.Fail)
-	ginkgo.RunSpecs(t, "route online debug suite")

Review comment:
       > @liuxiran how about removing this line instead of commenting out, just like other changes. While I think we could merge it first.
   
   yep, it should be removed or at least add a comment statement why it is commented out, It will be done with other code optimizations later, thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org