[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #369: HDDS-2755. Compare transactionID and updateID of Volume operations to avoid replaying transactions

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #369: HDDS-2755. Compare transactionID and updateID of Volume operations to avoid replaying transactions
URL: https://github.com/apache/hadoop-ozone/pull/369#discussion_r358978895
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeCreateRequest.java
 ##########
 @@ -132,7 +132,10 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
         }
       }
 
-      UserVolumeInfo volumeList = null;
+      // A replay transaction for CreateVolume can reach here only if the
+      // volume has been deleted in later transactions. Hence, we can
 
 Review comment:
   We can come here without delete request also right. Example CreateVolume T1,  but lastAppliedIndex is at zero, still it it not set to t1(As snapshot has not been taken) and OM restart. Not sure If i am missing something here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org