You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/22 05:07:51 UTC

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #7403: [WIP] #5791: Return 404 when requesting access to unexisting dashboard ID

mistercrunch commented on a change in pull request #7403: [WIP] #5791: Return 404 when requesting access to unexisting dashboard ID
URL: https://github.com/apache/incubator-superset/pull/7403#discussion_r286314674
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -71,6 +71,7 @@ def _fetch_metadata_for(datasource):
 
 class JavascriptPostAggregator(Postaggregator):
     def __init__(self, name, field_names, function):
+        Postaggregator.__init__(self, function, field_names, name)
 
 Review comment:
   Edits to this file seems unrelated to your PR title

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org