You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by bu...@apache.org on 2022/07/25 23:52:33 UTC

[Bug 66178] Reduce garbage from strings in AbstractArchiveResourceSet.getResource

https://bz.apache.org/bugzilla/show_bug.cgi?id=66178

Christopher Schultz <ch...@christopherschultz.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Garbage from strings in     |Reduce garbage from strings
                   |AbstractArchiveResourceSet. |in
                   |getResource                 |AbstractArchiveResourceSet.
                   |                            |getResource

--- Comment #2 from Christopher Schultz <ch...@christopherschultz.net> ---
Is this patch trying to reduce the use of temporary Strings in the heap?

I recently had conversation with someone about string concatenation in Java and
it's clear that modern compilers are more efficient when using source-level
concatenation instead of programmer-imposed uses of StringBuilder.

The code is less clear (to read, and thus less maintainable) when StringBuilder
is used and I'm not convinced that this will practically improve anything.

I'm a -0 on this for the time being.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org