You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/06/13 02:43:52 UTC

Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67564/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
    https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
-------

Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.


Diffs
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67564/diff/1/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Re: Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67564/#review205274
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 1869-1878 (patched)
<https://reviews.apache.org/r/67564/#comment288210>

    just some nits:
    
    could we have WillOnce and DoAll on the same line?


- Gilbert Song


On June 15, 2018, 4:54 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67564/
> -----------------------------------------------------------
> 
> (Updated June 15, 2018, 4:54 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
>     https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c 
> 
> 
> Diff: https://reviews.apache.org/r/67564/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67564/#review205325
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 1983-1984 (patched)
<https://reviews.apache.org/r/67564/#comment288248>

    the indentation should be like:
    
    ```
        .WillOnce(DoAll(
            FutureArg<1>(&startingUpdate),
            v1::scheduler::SendAcknowledge(frameworkId, offer.agent_id())))
    ```


- Gilbert Song


On June 25, 2018, 6:56 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67564/
> -----------------------------------------------------------
> 
> (Updated June 25, 2018, 6:56 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
>     https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp d1028e351c2ff395adc48489169597adbb0ce857 
> 
> 
> Diff: https://reviews.apache.org/r/67564/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67564/
-----------------------------------------------------------

(Updated June 25, 2018, 9:56 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
-------

Addressed review comments.


Bugs: MESOS-8327
    https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
-------

Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.


Diffs (updated)
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp d1028e351c2ff395adc48489169597adbb0ce857 


Diff: https://reviews.apache.org/r/67564/diff/3/

Changes: https://reviews.apache.org/r/67564/diff/2-3/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Re: Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67564/
-----------------------------------------------------------

(Updated June 15, 2018, 7:54 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
    https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
-------

Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.


Diffs (updated)
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67564/diff/2/

Changes: https://reviews.apache.org/r/67564/diff/1-2/


Testing
-------

sudo make check


Thanks,

Qian Zhang