You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/07/07 09:57:05 UTC

[GitHub] [echarts] Ovilia commented on a diff in pull request #16985: feat(gauge): axisLabel support angle rotating. close 15944

Ovilia commented on code in PR #16985:
URL: https://github.com/apache/echarts/pull/16985#discussion_r915689584


##########
src/chart/gauge/GaugeSeries.ts:
##########
@@ -172,6 +172,7 @@ export interface GaugeSeriesOption extends SeriesOption<GaugeStateOption, GaugeS
 
     axisLabel?: LabelOption & {
         formatter?: LabelFormatter | string
+        rotating?: boolean

Review Comment:
   I would suggest using `rotate` as the of [`series[sunburst].label.rotate`](https://echarts.apache.org/en/option.html#series-sunburst.label.rotate) and instead of using a `boolean` type, I think it would be more useful to provide the type `'tangential' | 'radial' | number`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org