You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2008/07/03 17:11:36 UTC
DO NOT REPLY [Bug 45333] New: Header directive deletes multiple
headers
https://issues.apache.org/bugzilla/show_bug.cgi?id=45333
Summary: Header directive deletes multiple headers
Product: Apache httpd-2
Version: 2.2.4
Platform: All
OS/Version: All
Status: NEW
Severity: critical
Priority: P1
Component: mod_headers
AssignedTo: bugs@httpd.apache.org
ReportedBy: marc.stern@approach.be
In case you have several headers with identical names (like Set-Cookie), which
is standard, and you use "header edit", only the first header is kept.
I reproduced this in a reverse proxymode, I'm not sure if it influences the
problem.
To reproduce:
1. Connect to an application that sends multiple Set-Cookie headers, like
SqirrelMail
2. Use the directive
Header edit Set-Cookie "even a non existing string" "replaced"
3. Only the first Set-Cookie header is transmitted
If you use "Header append", there is no problem.
This really screws up back-end applications when you want to edit headers.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45333] Header directive deletes multiple headers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45333
--- Comment #8 from Ruediger Pluem <rp...@apache.org> 2008-10-06 00:57:54 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > *** Bug 45952 has been marked as a duplicate of this bug. ***
> >
>
> ed.t = apr_table_make(r->pool, 5); - does it mean that the max number of
> headers with the same name is 5?
>
No. It does mean that the table reserves space for 5 entries at initialization.
See
http://apr.apache.org/docs/apr/1.3/group__apr__tables.html#g7b0a16a1388c68e66bff32190cf092f6
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45333] Header directive deletes multiple headers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45333
--- Comment #7 from Oleg Gryb <ol...@gryb.info> 2008-10-05 21:34:34 PST ---
(In reply to comment #6)
> *** Bug 45952 has been marked as a duplicate of this bug. ***
>
ed.t = apr_table_make(r->pool, 5); - does it mean that the max number of
headers with the same name is 5?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45333] Header directive deletes multiple headers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45333
Ruediger Pluem <rp...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Ruediger Pluem <rp...@apache.org> 2008-08-08 14:31:32 PST ---
Backported to 2.2.x as r684100
(http://svn.apache.org/viewvc?rev=684100&view=rev).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45333] Header directive deletes multiple headers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45333
Nick Kew <ni...@webthing.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oleg@gryb.info
--- Comment #6 from Nick Kew <ni...@webthing.com> 2008-10-05 19:35:09 PST ---
*** Bug 45952 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45333] Header directive deletes multiple headers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45333
--- Comment #10 from Ruediger Pluem <rp...@apache.org> 2008-10-15 12:59:16 PST ---
Backported to 2.2.10.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45333] Header directive deletes multiple headers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45333
--- Comment #9 from Oleg Gryb <ol...@gryb.info> 2008-10-06 07:05:15 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > *** Bug 45952 has been marked as a duplicate of this bug. ***
> > >
> >
> > ed.t = apr_table_make(r->pool, 5); - does it mean that the max number of
> > headers with the same name is 5?
> >
>
> No. It does mean that the table reserves space for 5 entries at initialization.
> See
> http://apr.apache.org/docs/apr/1.3/group__apr__tables.html#g7b0a16a1388c68e66bff32190cf092f6
>
Thanks, it should suffice then. I'm just curious why you need to create/delete
headers instead of just replacing header's values in place? Would not you agree
that replacing values in place will work faster (no need to create a new apr
table or create/delete the whole headers). I've tried to do that in
replace_values function. Could you think about any negative side-effects with
the latter solution?
Thanks again for the quick fix and reply - I should've checked the bugzilla
before posting.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45333] Header directive deletes multiple headers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45333
--- Comment #3 from Ruediger Pluem <rp...@apache.org> 2008-07-04 03:55:42 PST ---
Commited to trunk as r674000
(http://svn.apache.org/viewvc?view=rev&revision=674000).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45333] Header directive deletes multiple headers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45333
--- Comment #4 from Ruediger Pluem <rp...@apache.org> 2008-07-19 07:16:31 PST ---
Proposed for backport as r678164
(http://svn.apache.org/viewvc?view=rev&revision=678164).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45333] Header directive deletes multiple headers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45333
--- Comment #1 from Ruediger Pluem <rp...@apache.org> 2008-07-03 14:52:35 PST ---
Created an attachment (id=22213)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=22213)
Patch against trunk
Can you please check if the attached patch solves your problem?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45333] Header directive deletes multiple headers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45333
--- Comment #2 from Marc Stern <ma...@approach.be> 2008-07-04 00:17:18 PST ---
I tested it on 2.2.4 and it works - good job :-)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org