You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/06/13 08:14:12 UTC
[GitHub] [servicecomb-java-chassis] david6969xin opened a new pull request, #3067: [SCB-2565] ClassNotFoundException: javax.xml.bind.annotation:XmlRootE…
david6969xin opened a new pull request, #3067:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3067
fix [#3066](https://github.com/apache/servicecomb-java-chassis/issues/3066)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3067: [SCB-2565] ClassNotFoundException: javax.xml.bind.annotation:XmlRootE…
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3067:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3067#discussion_r895445177
##########
swagger/swagger-generator/generator-core/pom.xml:
##########
@@ -72,7 +72,6 @@
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
- <scope>test</scope>
Review Comment:
Yes, that's the way to fix it. But should we put it below these test dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] david6969xin commented on a diff in pull request #3067: [SCB-2565] ClassNotFoundException: javax.xml.bind.annotation:XmlRootE…
Posted by GitBox <gi...@apache.org>.
david6969xin commented on code in PR #3067:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3067#discussion_r895453919
##########
swagger/swagger-generator/generator-core/pom.xml:
##########
@@ -72,7 +72,6 @@
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
- <scope>test</scope>
Review Comment:
yes, It is better to adjust the order of dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3067: [SCB-2565] ClassNotFoundException: javax.xml.bind.annotation:XmlRootE…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3067:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3067#issuecomment-1153640198
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3067?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3067](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3067?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e7b0b8) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/7a755c1a6c9cde7d57857bfef230ce663e5964e6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a755c1) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5e7b0b8 differs from pull request most recent head 5234748. Consider uploading reports for the commit 5234748 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3067 +/- ##
=========================================
Coverage 77.50% 77.51%
Complexity 1414 1414
=========================================
Files 1611 1611
Lines 43215 43215
Branches 3640 3640
=========================================
+ Hits 33493 33497 +4
+ Misses 8224 8221 -3
+ Partials 1498 1497 -1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `10.86% <0.00%> (+1.08%)` | :arrow_up: |
| [...ecomb/provider/pojo/PojoConsumerMetaRefresher.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vUG9qb0NvbnN1bWVyTWV0YVJlZnJlc2hlci5qYXZh) | `78.04% <0.00%> (+2.43%)` | :arrow_up: |
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3067/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3067?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3067?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7a755c1...5234748](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3067?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj merged pull request #3067: [SCB-2565] ClassNotFoundException: javax.xml.bind.annotation:XmlRootE…
Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #3067:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org