[GitHub] [spark] xinrong-databricks commented on a change in pull request #34318: [SPARK-37048][PYTHON] Clean up inlining type hints under SQL module

[GitBox <gi...@apache.org>]

xinrong-databricks commented on a change in pull request #34318:
URL: https://github.com/apache/spark/pull/34318#discussion_r733038619



##########
File path: python/pyspark/sql/observation.py
##########
@@ -14,17 +14,16 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-from typing import Any, Dict, Optional, TYPE_CHECKING
+from typing import Any, Dict, Optional
+
+from py4j.java_gateway import JavaObject, JVMView

Review comment:
       I am still confused why some `from py4j.java_gateway import JavaObject` needs `# type: ignore[import]` though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org