svn commit: r1181956 - /hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java

[ns...@apache.org]

Author: nspiegelberg
Date: Tue Oct 11 17:44:12 2011
New Revision: 1181956

URL: http://svn.apache.org/viewvc?rev=1181956&view=rev
Log:
Fix logging of peak time compactions.

Summary:
There was a bug where the peak time logic used to throw warning
messages for default values.

Test Plan:
1) TestStore
2) Verify TestStore doesn't throw the warning messages.

Reviewers: kannan

Reviewed By: kannan

CC: pritam, hbase@lists, , kannan

Differential Revision: 314357

Modified:
    hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java

Modified: hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java?rev=1181956&r1=1181955&r2=1181956&view=diff
==============================================================================
--- hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java (original)
+++ hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java Tue Oct 11 17:44:12 2011
@@ -218,10 +218,12 @@ public class Store implements HeapSize {
     this.peakStartHour = conf.getInt("hbase.peak.start.hour", -1);
     this.peakEndHour = conf.getInt("hbase.peak.end.hour", -1);
     if (!isValidHour(this.peakStartHour) || !isValidHour(this.peakEndHour)) {
+      if (!(this.peakStartHour == -1 && this.peakEndHour == -1)) {
+        LOG.warn("Invalid start/end hour for peak hour : start = " +
+            this.peakStartHour + " end = " + this.peakEndHour +
+            ". Valid numbers are [0-23]");
+      }
       this.peakStartHour = this.peakEndHour = -1;
-      LOG.warn("Invalid start/end hour for peak hour : start = " +
-          this.peakStartHour + " end = " + this.peakEndHour +
-          ". Valid numbers are [0-23]");
     }
   }