Re: [PR] feat(dashboards): soft-delete and restore [superset]

["mikebridge (via GitHub)" <gi...@apache.org>]

mikebridge commented on code in PR #40128:
URL: https://github.com/apache/superset/pull/40128#discussion_r3508851037


##########
superset/translations/mi/LC_MESSAGES/messages.po:
##########
@@ -4372,6 +4372,9 @@ msgstr "Kāore i taea te whakahou i te whirihora tae papatohu."
 msgid "Dashboard could not be deleted."
 msgstr "Kāore i taea te muku i te papatohu."
 
+msgid "Dashboard could not be restored."
+msgstr ""

Review Comment:
   An empty `msgstr` is expected for newly-extracted strings — the `.po` catalogs carry the new message ids with empty translations until translators fill them in; an untranslated string falls back to the source text and is not a defect. Declining.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org