You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Olga Natkovich (JIRA)" <ji...@apache.org> on 2010/06/04 01:54:00 UTC
[jira] Created: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
make sure dependent jobs fail when a jon in multiquery fails
------------------------------------------------------------
Key: PIG-1435
URL: https://issues.apache.org/jira/browse/PIG-1435
Project: Pig
Issue Type: Bug
Reporter: Olga Natkovich
Fix For: 0.8.0
Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "niraj rai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
niraj rai updated PIG-1435:
---------------------------
Status: Open (was: Patch Available)
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "niraj rai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
niraj rai updated PIG-1435:
---------------------------
Attachment: depJobsFailure2.patch
review recommendations implemented
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch, depJobsFailure2.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1435:
--------------------------------
Status: Patch Available (was: Open)
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "niraj rai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
niraj rai updated PIG-1435:
---------------------------
Attachment: depJobsFailure3.patch
Made changes to make it compatible with PIG-1478
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch, depJobsFailure2.patch, depJobsFailure3.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "niraj rai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
niraj rai updated PIG-1435:
---------------------------
Status: Open (was: Patch Available)
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch, depJobsFailure2.patch, depJobsFailure3.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PIG-1435) make sure dependent jobs fail when a
jon in multiquery fails
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich reassigned PIG-1435:
-----------------------------------
Assignee: Richard Ding
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: Richard Ding
> Fix For: 0.8.0
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "niraj rai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
niraj rai updated PIG-1435:
---------------------------
Attachment: depJobs.patch
Attaching patch for the review
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1435) make sure dependent jobs fail when a
jon in multiquery fails
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890007#action_12890007 ]
Richard Ding commented on PIG-1435:
-----------------------------------
Looks good. A few comments:
* The new test class _test/org/apache/pig/test/utils/UPPER.java_ is missing Apache header and this results in the release audit warning.
* In the test case, the line
{code}
w.println("B = FOREACH A GENERATE UPPER(name);");
{code}
should be replaced by
{code}
w.println("B = FOREACH A GENERATE org.apache.pig.test.utils.UPPER(name);");
{code}
otherwise the builtin UDF UPPER is used and job will succeed.
* Also in the test case, should replace
{code}
if(js.getState().equals("FAILED")){
{code}
with
{code}
if(js.getState().name().equals("FAILED")){
{code}
to perform the string comparison.
* The logging in _MapReduceLauncher_
{code}
log.info("jobs" + job.getAssignedJobID() + " have failed!
{code}
should be written as
{code}
log.info("job " + job.getAssignedJobID() + " has failed!
{code}
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "niraj rai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
niraj rai updated PIG-1435:
---------------------------
Status: Patch Available (was: Open)
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch, depJobsFailure2.patch, depJobsFailure3.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1435) make sure dependent jobs fail when a
jon in multiquery fails
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889461#action_12889461 ]
Hadoop QA commented on PIG-1435:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12449609/depJobsFailure.patch
against trunk revision 964182.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 405 release audit warnings (more than the trunk's current 404 warnings).
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/371/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/371/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/371/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/371/console
This message is automatically generated.
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "niraj rai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
niraj rai updated PIG-1435:
---------------------------
Status: Patch Available (was: Open)
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "niraj rai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
niraj rai updated PIG-1435:
---------------------------
Attachment: depJobsFailure.patch
Fixed the hudson failure issues
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "niraj rai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
niraj rai updated PIG-1435:
---------------------------
Status: Patch Available (was: Open)
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch, depJobsFailure2.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1435) make sure dependent jobs fail when a
jon in multiquery fails
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888692#action_12888692 ]
Hadoop QA commented on PIG-1435:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12449486/depJobs.patch
against trunk revision 964182.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 405 release audit warnings (more than the trunk's current 404 warnings).
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/369/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/369/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/369/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/369/console
This message is automatically generated.
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1435:
------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
Patch committed to trunk. Thanks Niraj.
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch, depJobsFailure2.patch, depJobsFailure3.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1435) make sure dependent jobs fail when a jon
in multiquery fails
Posted by "niraj rai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
niraj rai updated PIG-1435:
---------------------------
Status: Open (was: Patch Available)
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch, depJobsFailure2.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PIG-1435) make sure dependent jobs fail when a
jon in multiquery fails
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding reassigned PIG-1435:
---------------------------------
Assignee: niraj rai (was: Richard Ding)
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As the result, if data was partially generated by the failed job, you might get incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.