You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Bruno Bowden (JIRA)" <ji...@apache.org> on 2008/02/01 04:15:10 UTC

[jira] Created: (SHINDIG-43) jre1.5 (works on jre1.6) does not include dependent features

jre1.5 (works on jre1.6) does not include dependent features
------------------------------------------------------------

                 Key: SHINDIG-43
                 URL: https://issues.apache.org/jira/browse/SHINDIG-43
             Project: Shindig
          Issue Type: Bug
          Components: Gadgets Server - Java
         Environment: jdk1.5.0
            Reporter: Bruno Bowden
            Assignee: John Hjelmstad
            Priority: Blocker


The ifpc feature depends on core, which inludes several js libraries such as json.js.

When making this request it should return both ifpc.js and json.js in the same file:

    http://localhost:8080/gadgets/js/ifpc.js

On jdk1.6.0 this works correctly. However on jdk.1.5.0 it fails, only returning ifpc.js and none of the transitive dependencies. This will cause most gadgets to break as the core libraries will not be available.

FAILS: jdk1.5.0
WORKS: jdk1.6.0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-43) jre1.5 (works on jre1.6) does not include dependent features

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-43.
---------------------------------

    Resolution: Fixed

Added 'core' dependencies for features that had no dependencies.  I noticed that things like flash and views appeared above core, perhaps that's why.

Tested on jdk 1.5 on macos leopard.  Samples appear much better, but samplecontainer still has some problems that are probably not related to this..



> jre1.5 (works on jre1.6) does not include dependent features
> ------------------------------------------------------------
>
>                 Key: SHINDIG-43
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-43
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadgets Server - Java
>         Environment: jdk1.5.0
>            Reporter: Bruno Bowden
>            Assignee: John Hjelmstad
>            Priority: Blocker
>
> The ifpc feature depends on core, which inludes several js libraries such as json.js.
> When making this request it should return both ifpc.js and json.js in the same file:
>     http://localhost:8080/gadgets/js/ifpc.js
> On jdk1.6.0 this works correctly. However on jdk.1.5.0 it fails, only returning ifpc.js and none of the transitive dependencies. This will cause most gadgets to break as the core libraries will not be available.
> FAILS: jdk1.5.0
> WORKS: jdk1.6.0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-43) jre1.5 (works on jre1.6) does not include dependent features

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570906#action_12570906 ] 

Paul Lindner commented on SHINDIG-43:
-------------------------------------

What's the plan to fix this?  SHINDIG-79 and SHINDIG-80?

Right now we've got a lot of balls flying in the air, we should get better coordinated.


> jre1.5 (works on jre1.6) does not include dependent features
> ------------------------------------------------------------
>
>                 Key: SHINDIG-43
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-43
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadgets Server - Java
>         Environment: jdk1.5.0
>            Reporter: Bruno Bowden
>            Assignee: John Hjelmstad
>            Priority: Blocker
>         Attachments: SHINDIG-43.patch
>
>
> The ifpc feature depends on core, which inludes several js libraries such as json.js.
> When making this request it should return both ifpc.js and json.js in the same file:
>     http://localhost:8080/gadgets/js/ifpc.js
> On jdk1.6.0 this works correctly. However on jdk.1.5.0 it fails, only returning ifpc.js and none of the transitive dependencies. This will cause most gadgets to break as the core libraries will not be available.
> FAILS: jdk1.5.0
> WORKS: jdk1.6.0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-43) jre1.5 (works on jre1.6) does not include dependent features

Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570890#action_12570890 ] 

Kevin Brown commented on SHINDIG-43:
------------------------------------

This doesn't solve the issue because there are more things that are "core" than the "core" feature; you'd have to add dependencies on every other core feature (both in the features/ directory, and the more complicated ones that are implemented in java).

core.io depends on core to ensure that the dependency graph is resolved correctly. It was moved out of the main "core" directory because it needs custom configuration independent of the rest of core. 

> jre1.5 (works on jre1.6) does not include dependent features
> ------------------------------------------------------------
>
>                 Key: SHINDIG-43
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-43
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadgets Server - Java
>         Environment: jdk1.5.0
>            Reporter: Bruno Bowden
>            Assignee: John Hjelmstad
>            Priority: Blocker
>         Attachments: SHINDIG-43.patch
>
>
> The ifpc feature depends on core, which inludes several js libraries such as json.js.
> When making this request it should return both ifpc.js and json.js in the same file:
>     http://localhost:8080/gadgets/js/ifpc.js
> On jdk1.6.0 this works correctly. However on jdk.1.5.0 it fails, only returning ifpc.js and none of the transitive dependencies. This will cause most gadgets to break as the core libraries will not be available.
> FAILS: jdk1.5.0
> WORKS: jdk1.6.0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (SHINDIG-43) jre1.5 (works on jre1.6) does not include dependent features

Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Brown reopened SHINDIG-43:
--------------------------------


This does not fix the issue, it hides it. Please revert this change.

> jre1.5 (works on jre1.6) does not include dependent features
> ------------------------------------------------------------
>
>                 Key: SHINDIG-43
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-43
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadgets Server - Java
>         Environment: jdk1.5.0
>            Reporter: Bruno Bowden
>            Assignee: John Hjelmstad
>            Priority: Blocker
>
> The ifpc feature depends on core, which inludes several js libraries such as json.js.
> When making this request it should return both ifpc.js and json.js in the same file:
>     http://localhost:8080/gadgets/js/ifpc.js
> On jdk1.6.0 this works correctly. However on jdk.1.5.0 it fails, only returning ifpc.js and none of the transitive dependencies. This will cause most gadgets to break as the core libraries will not be available.
> FAILS: jdk1.5.0
> WORKS: jdk1.6.0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-43) jre1.5 (works on jre1.6) does not include dependent features

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570882#action_12570882 ] 

Paul Lindner commented on SHINDIG-43:
-------------------------------------

Kevin, can you contact me directly?

This problem affects Mac OS X Java 1.6, so my development is seriously blocked without it, as I'm sure others will be.

It may not solve the problem in the correct way, but it does serve to work around the problem.

How about instead of treating core 'special' we just make sure that it's the only feature without a parent?  Accomplishes the same goal, right?

Also, can you explain why the core.io feature has a dependency on "core"

Feel free to IM me at pmlindner@gmail.com (GTalk) or drop by #shindig on irc.freenode.net



> jre1.5 (works on jre1.6) does not include dependent features
> ------------------------------------------------------------
>
>                 Key: SHINDIG-43
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-43
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadgets Server - Java
>         Environment: jdk1.5.0
>            Reporter: Bruno Bowden
>            Assignee: John Hjelmstad
>            Priority: Blocker
>         Attachments: SHINDIG-43.patch
>
>
> The ifpc feature depends on core, which inludes several js libraries such as json.js.
> When making this request it should return both ifpc.js and json.js in the same file:
>     http://localhost:8080/gadgets/js/ifpc.js
> On jdk1.6.0 this works correctly. However on jdk.1.5.0 it fails, only returning ifpc.js and none of the transitive dependencies. This will cause most gadgets to break as the core libraries will not be available.
> FAILS: jdk1.5.0
> WORKS: jdk1.6.0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SHINDIG-43) jre1.5 (works on jre1.6) does not include dependent features

Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Brown closed SHINDIG-43.
------------------------------

    Resolution: Fixed

fixed in rev629709

> jre1.5 (works on jre1.6) does not include dependent features
> ------------------------------------------------------------
>
>                 Key: SHINDIG-43
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-43
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadgets Server - Java
>         Environment: jdk1.5.0
>            Reporter: Bruno Bowden
>            Assignee: John Hjelmstad
>            Priority: Blocker
>         Attachments: SHINDIG-43.patch
>
>
> The ifpc feature depends on core, which inludes several js libraries such as json.js.
> When making this request it should return both ifpc.js and json.js in the same file:
>     http://localhost:8080/gadgets/js/ifpc.js
> On jdk1.6.0 this works correctly. However on jdk.1.5.0 it fails, only returning ifpc.js and none of the transitive dependencies. This will cause most gadgets to break as the core libraries will not be available.
> FAILS: jdk1.5.0
> WORKS: jdk1.6.0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-43) jre1.5 (works on jre1.6) does not include dependent features

Posted by "Matt Raible (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Raible updated SHINDIG-43:
-------------------------------

    Attachment: SHINDIG-43.patch

The following patch seems like it may solve the problem, but I'm not sure. At the very least, it makes the results consistent between Java 5 and Java 6.

Before the patch, here's the results in Java 5:

# jsFeatures: 13
core.io
rpc
opensocial-reference
opensocial-samplecontainer
analytics
flash 
skins
views
minimessage
settitle
dynamic-height
tabs
setprefs

In Java 6:

# jsFeatures: 16
flash 
ifpc
analytics
caja
opensocial-reference
opensocial-samplecontainer
rpc
views
dynamic-height
setprefs
core
settitle
minimessage
skins
core.io
tabs

After the patch:

# jsFeatures: 14
analytics
caja
core.io
dynamic-height
flash
ifpc
minimessage
opensocial-reference
opensocial-samplecontainer
setprefs
settitle
skins
tabs
views

> jre1.5 (works on jre1.6) does not include dependent features
> ------------------------------------------------------------
>
>                 Key: SHINDIG-43
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-43
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadgets Server - Java
>         Environment: jdk1.5.0
>            Reporter: Bruno Bowden
>            Assignee: John Hjelmstad
>            Priority: Blocker
>         Attachments: SHINDIG-43.patch
>
>
> The ifpc feature depends on core, which inludes several js libraries such as json.js.
> When making this request it should return both ifpc.js and json.js in the same file:
>     http://localhost:8080/gadgets/js/ifpc.js
> On jdk1.6.0 this works correctly. However on jdk.1.5.0 it fails, only returning ifpc.js and none of the transitive dependencies. This will cause most gadgets to break as the core libraries will not be available.
> FAILS: jdk1.5.0
> WORKS: jdk1.6.0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.