You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/21 15:00:43 UTC

[GitHub] [logging-log4j2] avandeursen commented on pull request #721: Expand test suite for DateLookup

avandeursen commented on pull request #721:
URL: https://github.com/apache/logging-log4j2/pull/721#issuecomment-1018587402


   Thanks! Based on the feedback I made a few changes.
   
   For the test with the known format, I indeed added the test whether the returned date is today (and even added a test for tomorrow, in case the test is executed at midnight).
   
   For the test cases falling back on the default format, most likely the time is included in that format, making this route a bit too flaky to my taste. So I decided to better document the rationale of the test instead.
   
   While engaging with the DateLookup class, I also made some of the javadocs more accurate.
   
   Let me know what you think!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org