[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2597: [GOBBLIN-730] added job start and end time in flow status retriever

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2597: [GOBBLIN-730] added job start and end time in flow status retriever
URL: https://github.com/apache/incubator-gobblin/pull/2597#discussion_r275122898
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java
 ##########
 @@ -48,8 +48,11 @@
  * A FileSystem based implementation of {@link JobStatusRetriever}. This implementation stores the job statuses
  * as {@link org.apache.gobblin.configuration.State} objects in a {@link FsStateStore}.
  * The store name is set to flowGroup.flowName, while the table name is set to flowExecutionId.jobGroup.jobName.
+ *
+ * This retriever is deprecated in favour of {@link MysqlJobStatusRetriever}.
  */
 @Slf4j
+@Deprecated
 
 Review comment:
   I don't this should be deprecated. We should support both JobStatusRetriever implementations.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services