You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Bryan Ellis <er...@apache.org> on 2020/05/20 08:12:50 UTC

Re: [DISCUSS] cordova-ios 6.0.0 Major Release

This is a followup, I will be preparing the iOS release this Friday (about ~48hrs from now).

There are a few remaining PRs that could be merged but requires review, rebasing, etc.

IF these PRs are not prepared or merged in by then, they will be dropped from this release and postponed for next major. (sometime maybe mid-2021)

PRs:

* #851 - breaking: replace shelljs with fs-extra
  * https://github.com/apache/cordova-ios/pull/851 <https://github.com/apache/cordova-ios/pull/851>

* #859 - refactor: use superspawn
  * https://github.com/apache/cordova-ios/pull/859 <https://github.com/apache/cordova-ios/pull/859> 
  * Requires #851

* #860 - breaking: drop q dependency
  * https://github.com/apache/cordova-ios/pull/860 <https://github.com/apache/cordova-ios/pull/860>
  * Requires #851 & #859

* #861 - chore: add package-lock.json
  * https://github.com/apache/cordova-ios/pull/861 <https://github.com/apache/cordova-ios/pull/861>
  * Preferably merged after #860
  * Requires Rebasing after #860

* #852 - ci: use github actions
  * https://github.com/apache/cordova-ios/pull/852 <https://github.com/apache/cordova-ios/pull/852>
  * Requires #861

* #790 CB-13143: Integrate and replace SplashScreens with Launch Storyboard
  * https://github.com/apache/cordova-ios/pull/790 <https://github.com/apache/cordova-ios/pull/790>
  * Requires a rebase

* #808 - (iOS) Dark mode splashscreen storyboard images
  * https://github.com/apache/cordova-ios/pull/808 <https://github.com/apache/cordova-ios/pull/808>
  * Preferably merged after #790

As for the reaming PRs that were mentioned previously and not listed above:

> - https://github.com/apache/cordova-ios/pull/823 <https://github.com/apache/cordova-ios/pull/823>
* I left a comment asking for additional feed back and a concern with the change.
* No reply has been received.
* I believe this PR will not make it in this release.

> - https://github.com/apache/cordova-ios/pull/763 <https://github.com/apache/cordova-ios/pull/763>
* This PR was closed out with out merge.
* It has been replaced with #859 & #860

> - https://github.com/apache/cordova-ios/pull/454 <https://github.com/apache/cordova-ios/pull/454>* There is a comment/request to wrap the changes with a flag so it doesn’t change the default.
* This request was not been completed.
* I believe this PR will not make it in this release. 



> On Apr 19, 2020, at 3:35, Darryl Pogue <dv...@gmail.com> wrote:
> 
> I've just merged two very small PRs:
> - https://github.com/apache/cordova-ios/pull/615
> - https://github.com/apache/cordova-ios/pull/825
> 
> There are some others that would be nice to get in, but require more
> testing or more work to finish:
> - https://github.com/apache/cordova-ios/pull/823
> - https://github.com/apache/cordova-ios/pull/790
> - https://github.com/apache/cordova-ios/pull/763
> - https://github.com/apache/cordova-ios/pull/454
> 
> On Fri, Apr 17, 2020 at 10:56 PM Bryan Ellis <er...@apache.org> wrote:
> 
>> Does anyone have any reason to delay a cordova-ios major release (6.0.0)?
>> 
>> Any additional outstanding changes to land?
>> 
>> If not, I will start the release process in the next couple of days.
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>> 
>> 


Re: [DISCUSS] cordova-ios 6.0.0 Major Release

Posted by julio cesar sanchez <jc...@gmail.com>.
The podspec issue is not breaking, we can publish on next patch or minor
release.

El El vie, 5 jun 2020 a las 22:00, Chris Brody <ch...@gmail.com>
escribió:

> Looks like we missed breaking PR #795:
> https://github.com/apache/cordova-ios/pull/795
>
> I just put #795 into new 7.0.0 milestone, along with the podspec issue:
> https://github.com/apache/cordova-ios/issues/887
>
>
> On Wed, May 20, 2020 at 4:13 AM Bryan Ellis <er...@apache.org> wrote:
>
> > This is a followup, I will be preparing the iOS release this Friday
> (about
> > ~48hrs from now).
> >
> > There are a few remaining PRs that could be merged but requires review,
> > rebasing, etc.
> >
> > IF these PRs are not prepared or merged in by then, they will be dropped
> > from this release and postponed for next major. (sometime maybe mid-2021)
> >
> > PRs:
> >
> > * #851 - breaking: replace shelljs with fs-extra
> >   * https://github.com/apache/cordova-ios/pull/851 <
> > https://github.com/apache/cordova-ios/pull/851>
> >
> > * #859 - refactor: use superspawn
> >   * https://github.com/apache/cordova-ios/pull/859 <
> > https://github.com/apache/cordova-ios/pull/859>
> >   * Requires #851
> >
> > * #860 - breaking: drop q dependency
> >   * https://github.com/apache/cordova-ios/pull/860 <
> > https://github.com/apache/cordova-ios/pull/860>
> >   * Requires #851 & #859
> >
> > * #861 - chore: add package-lock.json
> >   * https://github.com/apache/cordova-ios/pull/861 <
> > https://github.com/apache/cordova-ios/pull/861>
> >   * Preferably merged after #860
> >   * Requires Rebasing after #860
> >
> > * #852 - ci: use github actions
> >   * https://github.com/apache/cordova-ios/pull/852 <
> > https://github.com/apache/cordova-ios/pull/852>
> >   * Requires #861
> >
> > * #790 CB-13143: Integrate and replace SplashScreens with Launch
> Storyboard
> >   * https://github.com/apache/cordova-ios/pull/790 <
> > https://github.com/apache/cordova-ios/pull/790>
> >   * Requires a rebase
> >
> > * #808 - (iOS) Dark mode splashscreen storyboard images
> >   * https://github.com/apache/cordova-ios/pull/808 <
> > https://github.com/apache/cordova-ios/pull/808>
> >   * Preferably merged after #790
> >
> > As for the reaming PRs that were mentioned previously and not listed
> above:
> >
> > > - https://github.com/apache/cordova-ios/pull/823 <
> > https://github.com/apache/cordova-ios/pull/823>
> > * I left a comment asking for additional feed back and a concern with the
> > change.
> > * No reply has been received.
> > * I believe this PR will not make it in this release.
> >
> > > - https://github.com/apache/cordova-ios/pull/763 <
> > https://github.com/apache/cordova-ios/pull/763>
> > * This PR was closed out with out merge.
> > * It has been replaced with #859 & #860
> >
> > > - https://github.com/apache/cordova-ios/pull/454 <
> > https://github.com/apache/cordova-ios/pull/454>* There is a
> > comment/request to wrap the changes with a flag so it doesn’t change the
> > default.
> > * This request was not been completed.
> > * I believe this PR will not make it in this release.
> >
> >
> >
> > > On Apr 19, 2020, at 3:35, Darryl Pogue <dv...@gmail.com> wrote:
> > >
> > > I've just merged two very small PRs:
> > > - https://github.com/apache/cordova-ios/pull/615
> > > - https://github.com/apache/cordova-ios/pull/825
> > >
> > > There are some others that would be nice to get in, but require more
> > > testing or more work to finish:
> > > - https://github.com/apache/cordova-ios/pull/823
> > > - https://github.com/apache/cordova-ios/pull/790
> > > - https://github.com/apache/cordova-ios/pull/763
> > > - https://github.com/apache/cordova-ios/pull/454
> > >
> > > On Fri, Apr 17, 2020 at 10:56 PM Bryan Ellis <er...@apache.org> wrote:
> > >
> > >> Does anyone have any reason to delay a cordova-ios major release
> > (6.0.0)?
> > >>
> > >> Any additional outstanding changes to land?
> > >>
> > >> If not, I will start the release process in the next couple of days.
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >>
> >
> >
>

Re: [DISCUSS] cordova-ios 6.0.0 Major Release

Posted by Chris Brody <ch...@gmail.com>.
Looks like we missed breaking PR #795:
https://github.com/apache/cordova-ios/pull/795

I just put #795 into new 7.0.0 milestone, along with the podspec issue:
https://github.com/apache/cordova-ios/issues/887


On Wed, May 20, 2020 at 4:13 AM Bryan Ellis <er...@apache.org> wrote:

> This is a followup, I will be preparing the iOS release this Friday (about
> ~48hrs from now).
>
> There are a few remaining PRs that could be merged but requires review,
> rebasing, etc.
>
> IF these PRs are not prepared or merged in by then, they will be dropped
> from this release and postponed for next major. (sometime maybe mid-2021)
>
> PRs:
>
> * #851 - breaking: replace shelljs with fs-extra
>   * https://github.com/apache/cordova-ios/pull/851 <
> https://github.com/apache/cordova-ios/pull/851>
>
> * #859 - refactor: use superspawn
>   * https://github.com/apache/cordova-ios/pull/859 <
> https://github.com/apache/cordova-ios/pull/859>
>   * Requires #851
>
> * #860 - breaking: drop q dependency
>   * https://github.com/apache/cordova-ios/pull/860 <
> https://github.com/apache/cordova-ios/pull/860>
>   * Requires #851 & #859
>
> * #861 - chore: add package-lock.json
>   * https://github.com/apache/cordova-ios/pull/861 <
> https://github.com/apache/cordova-ios/pull/861>
>   * Preferably merged after #860
>   * Requires Rebasing after #860
>
> * #852 - ci: use github actions
>   * https://github.com/apache/cordova-ios/pull/852 <
> https://github.com/apache/cordova-ios/pull/852>
>   * Requires #861
>
> * #790 CB-13143: Integrate and replace SplashScreens with Launch Storyboard
>   * https://github.com/apache/cordova-ios/pull/790 <
> https://github.com/apache/cordova-ios/pull/790>
>   * Requires a rebase
>
> * #808 - (iOS) Dark mode splashscreen storyboard images
>   * https://github.com/apache/cordova-ios/pull/808 <
> https://github.com/apache/cordova-ios/pull/808>
>   * Preferably merged after #790
>
> As for the reaming PRs that were mentioned previously and not listed above:
>
> > - https://github.com/apache/cordova-ios/pull/823 <
> https://github.com/apache/cordova-ios/pull/823>
> * I left a comment asking for additional feed back and a concern with the
> change.
> * No reply has been received.
> * I believe this PR will not make it in this release.
>
> > - https://github.com/apache/cordova-ios/pull/763 <
> https://github.com/apache/cordova-ios/pull/763>
> * This PR was closed out with out merge.
> * It has been replaced with #859 & #860
>
> > - https://github.com/apache/cordova-ios/pull/454 <
> https://github.com/apache/cordova-ios/pull/454>* There is a
> comment/request to wrap the changes with a flag so it doesn’t change the
> default.
> * This request was not been completed.
> * I believe this PR will not make it in this release.
>
>
>
> > On Apr 19, 2020, at 3:35, Darryl Pogue <dv...@gmail.com> wrote:
> >
> > I've just merged two very small PRs:
> > - https://github.com/apache/cordova-ios/pull/615
> > - https://github.com/apache/cordova-ios/pull/825
> >
> > There are some others that would be nice to get in, but require more
> > testing or more work to finish:
> > - https://github.com/apache/cordova-ios/pull/823
> > - https://github.com/apache/cordova-ios/pull/790
> > - https://github.com/apache/cordova-ios/pull/763
> > - https://github.com/apache/cordova-ios/pull/454
> >
> > On Fri, Apr 17, 2020 at 10:56 PM Bryan Ellis <er...@apache.org> wrote:
> >
> >> Does anyone have any reason to delay a cordova-ios major release
> (6.0.0)?
> >>
> >> Any additional outstanding changes to land?
> >>
> >> If not, I will start the release process in the next couple of days.
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >>
>
>