You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cfmcgrady (via GitHub)" <gi...@apache.org> on 2023/07/26 10:48:20 UTC
[GitHub] [incubator-celeborn] cfmcgrady opened a new pull request, #1763: [CELEBORN-822][FOLLOWUP] Format the example code in the docs/README.md
cfmcgrady opened a new pull request, #1763:
URL: https://github.com/apache/incubator-celeborn/pull/1763
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
As title
### Why are the changes needed?
make it more clarity and readability
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cfmcgrady commented on pull request #1763: [CELEBORN-822][FOLLOWUP] Format the example code in the docs/README.md
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #1763:
URL: https://github.com/apache/incubator-celeborn/pull/1763#issuecomment-1651538527
@pan3793 @waitinfuture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1763: [CELEBORN-822][FOLLOWUP] Format the example code in the docs/README.md
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1763:
URL: https://github.com/apache/incubator-celeborn/pull/1763#discussion_r1274794665
##########
docs/README.md:
##########
@@ -58,13 +58,13 @@ cd $CELEBORN_HOME
./sbin/start-worker.sh celeborn://${Master IP}:${Master Port}
Review Comment:
```suggestion
./sbin/start-worker.sh celeborn://<Master IP>:<Master Port>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cfmcgrady commented on pull request #1763: [CELEBORN-822][FOLLOWUP] Format the example code in the docs/README.md
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #1763:
URL: https://github.com/apache/incubator-celeborn/pull/1763#issuecomment-1651556425
> Can we strip the leading timestamp from logs too?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1763: [CELEBORN-822][FOLLOWUP] Format the example code in the docs/README.md
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1763:
URL: https://github.com/apache/incubator-celeborn/pull/1763#issuecomment-1651540133
Can we strip the leading timestamp from logs too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1763: [CELEBORN-822][FOLLOWUP] Format the example code in the docs/README.md
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1763: [CELEBORN-822][FOLLOWUP] Format the example code in the docs/README.md
URL: https://github.com/apache/incubator-celeborn/pull/1763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1763: [CELEBORN-822][FOLLOWUP] Format the example code in the docs/README.md
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1763:
URL: https://github.com/apache/incubator-celeborn/pull/1763#issuecomment-1651555651
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1763?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1763](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1763?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (37a1c50) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/e708c3cd25269f860159ea6b36ab232a553574e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e708c3c) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 37a1c50 differs from pull request most recent head dc2eca6. Consider uploading reports for the commit dc2eca6 to get more accurate results
```diff
@@ Coverage Diff @@
## main #1763 +/- ##
=======================================
Coverage 46.74% 46.74%
=======================================
Files 162 162
Lines 10026 10026
Branches 925 925
=======================================
Hits 4686 4686
Misses 5021 5021
Partials 319 319
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org