You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2025/04/28 23:29:55 UTC
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
HyukjinKwon commented on code in PR #50714:
URL: https://github.com/apache/spark/pull/50714#discussion_r2065009631
##########
python/pyspark/sql/classic/dataframe.py:
##########
@@ -1190,7 +1190,7 @@ def dropDuplicatesWithinWatermark(self, subset: Optional[List[str]] = None) -> P
messageParameters={"arg_name": "subset", "arg_type": type(subset).__name__},
)
- if subset is None:
+ if not subset:
Review Comment:
yeah I prefer to be explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org