[GitHub] spark pull request #21923: [SPARK-24918][Core] Executor Plugin api

[tgravescs <gi...@git.apache.org>]

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21923#discussion_r206905166
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -130,6 +130,12 @@ private[spark] class Executor(
       private val urlClassLoader = createClassLoader()
       private val replClassLoader = addReplClassLoaderIfNeeded(urlClassLoader)
     
    +  Thread.currentThread().setContextClassLoader(replClassLoader)
    --- End diff --
    
    do we want to do it in the same thread?  It might be safer in a separate thread. Does that affect your memory monitor?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org