You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2021/01/19 11:53:09 UTC
[GitHub] [myfaces] bohmber opened a new pull request #152: MYFACES-4376
bohmber opened a new pull request #152:
URL: https://github.com/apache/myfaces/pull/152
Update Cryptographic algorithm in StateUtils to a stronger version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] bohmber commented on pull request #152: MYFACES-4376
Posted by GitBox <gi...@apache.org>.
bohmber commented on pull request #152:
URL: https://github.com/apache/myfaces/pull/152#issuecomment-764539983
@volosied should I apply this to 3.0.x as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #152: MYFACES-4376
Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #152:
URL: https://github.com/apache/myfaces/pull/152#issuecomment-762856879
somehow yes, in general its a completely cleaned-up 2.3, which i created as preperation for 4.0.
Currently 2.3-next equals 4.0, but with jakarta namespace and @ClientWindowScoped prototype.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] bohmber commented on pull request #152: MYFACES-4376
Posted by GitBox <gi...@apache.org>.
bohmber commented on pull request #152:
URL: https://github.com/apache/myfaces/pull/152#issuecomment-762798710
It's based on this https://github.com/apache/myfaces/security/code-scanning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko edited a comment on pull request #152: MYFACES-4376
Posted by GitBox <gi...@apache.org>.
tandraschko edited a comment on pull request #152:
URL: https://github.com/apache/myfaces/pull/152#issuecomment-762856879
somehow yes, in general its a completely cleaned-up 2.3, which i created as preperation for 4.0.
Currently 2.3-next equals 4.0, but with jakarta namespace and @ClientWindowScoped prototype.
Im also ok to not merge it, we should just decide how we maintain 2.3-next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko edited a comment on pull request #152: MYFACES-4376
Posted by GitBox <gi...@apache.org>.
tandraschko edited a comment on pull request #152:
URL: https://github.com/apache/myfaces/pull/152#issuecomment-762856879
somehow yes, in general its a completely cleaned-up 2.3, which i created as preperation for 4.0.
Currently 4.0 equals 2.3-next, but with jakarta namespace and @ClientWindowScoped prototype.
Im also ok to not merge it, we should just decide how we maintain 2.3-next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #152: MYFACES-4376
Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #152:
URL: https://github.com/apache/myfaces/pull/152#issuecomment-762807569
also dont forget the homepage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] bohmber commented on pull request #152: MYFACES-4376
Posted by GitBox <gi...@apache.org>.
bohmber commented on pull request #152:
URL: https://github.com/apache/myfaces/pull/152#issuecomment-764539983
@volosied should I apply this to 3.0.x as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #152: MYFACES-4376
Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #152:
URL: https://github.com/apache/myfaces/pull/152#issuecomment-762795428
+1
please also add it to 2.3-next, thats the only version currently usable by Quarkus users and its the same codebase as 4.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko edited a comment on pull request #152: MYFACES-4376
Posted by GitBox <gi...@apache.org>.
tandraschko edited a comment on pull request #152:
URL: https://github.com/apache/myfaces/pull/152#issuecomment-762795428
+1 if well tested, code looks fine
please also add it to 2.3-next, thats the only version currently usable by Quarkus users and its the same codebase as 4.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] bohmber merged pull request #152: MYFACES-4376
Posted by GitBox <gi...@apache.org>.
bohmber merged pull request #152:
URL: https://github.com/apache/myfaces/pull/152
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] bohmber commented on pull request #152: MYFACES-4376
Posted by GitBox <gi...@apache.org>.
bohmber commented on pull request #152:
URL: https://github.com/apache/myfaces/pull/152#issuecomment-762854851
@tandraschko
Is 2.3-next just a improved replacement for 2.3.x? If yes then I shouldn't apply the change to AES for 2.3-next
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org