[GitHub] [solr] risdenk commented on a change in pull request #748: SOLR-16103 Increase CodeCache size for test JVM

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #748:
URL: https://github.com/apache/solr/pull/748#discussion_r828434132



##########
File path: gradle/testing/defaults-tests.gradle
##########
@@ -47,7 +47,7 @@ allprojects {
            description: "Number of forked test JVMs"],
           [propName: 'tests.haltonfailure', value: true, description: "Halt processing on test failure."],
           [propName: 'tests.jvmargs',
-           value: { -> propertyOrEnvOrDefault("tests.jvmargs", "TEST_JVM_ARGS", "-XX:TieredStopAtLevel=1") },
+           value: { -> propertyOrEnvOrDefault("tests.jvmargs", "TEST_JVM_ARGS", "-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m") },

Review comment:
       `-XX:ReservedCodeCacheSize=120m`
   
    Is `120m` just a guess at this point?
   
   Can we add a comment about why? Maybe a "the JDK sets this to XYZm and we need at least 120m".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org