[GitHub] spark pull request #15819: [SPARK-18372][SQL].Staging directory fail to be r...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15819#discussion_r90782492
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala ---
    @@ -54,6 +61,61 @@ case class InsertIntoHiveTable(
       @transient private lazy val hiveContext = new Context(sc.hiveconf)
       @transient private lazy val catalog = sc.catalog
     
    +  val stagingDir = new HiveConf().getVar(HiveConf.ConfVars.STAGINGDIR)
    +
    +  private def executionId: String = {
    +    val rand: Random = new Random
    +    val format: SimpleDateFormat = new SimpleDateFormat("yyyy-MM-dd_HH-mm-ss_SSS")
    +    val executionId: String = "hive_" + format.format(new Date) + "_" + Math.abs(rand.nextLong)
    +    return executionId
    +  }
    +
    +  private def getStagingDir(inputPath: Path, hadoopConf: Configuration): Path = {
    +    val inputPathUri: URI = inputPath.toUri
    +    val inputPathName: String = inputPathUri.getPath
    +    val fs: FileSystem = inputPath.getFileSystem(hadoopConf)
    +    val stagingPathName: String =
    +      if (inputPathName.indexOf(stagingDir) == -1) {
    +        new Path(inputPathName, stagingDir).toString
    +      } else {
    +        inputPathName.substring(0, inputPathName.indexOf(stagingDir) + stagingDir.length)
    +      }
    +    val dir: Path =
    +      fs.makeQualified(
    +        new Path(stagingPathName + "_" + executionId + "-" + TaskRunner.getTaskRunnerID))
    +    logDebug("Created staging dir = " + dir + " for path = " + inputPath)
    +    try {
    +      if (!FileUtils.mkdir(fs, dir, true, hadoopConf)) {
    +        throw new IllegalStateException("Cannot create staging directory  '" + dir.toString + "'")
    +      }
    +      fs.deleteOnExit(dir)
    +    }
    +    catch {
    +      case e: IOException =>
    +        throw new RuntimeException(
    --- End diff --
    
    Almost all the codes in this PR are copied from the existing master. This PR is just for branch 1.6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org