[GitHub] [fineract] fynmanoj opened a new pull request #1328: FINERACT-1106-rework-skip-holiday-for-first-reschedule-date

[GitBox <gi...@apache.org>]

fynmanoj opened a new pull request #1328:
URL: https://github.com/apache/fineract/pull/1328


   ## Description
   
   1. Instead of throwing error for first repayment falling on a holiday,  the repayment is adjusted to fall on a working day.
   2. This feature can be controlled by the configuration "loan-reschedule-is-first-payday-allowed-on-holiday"
   
   Describe the changes made and why they were made.
   
   Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] avikganguly01 merged pull request #1328: FINERACT-1106-rework-skip-holiday-for-first-reschedule-date

[GitBox <gi...@apache.org>]

avikganguly01 merged pull request #1328:
URL: https://github.com/apache/fineract/pull/1328


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org