You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@ofbiz.apache.org by Cimballi <ci...@cimballi.net> on 2009/05/29 20:41:21 UTC

Bug in Lookup Order(s) screen when no status selected

Hi,

There is another bug in the Lookup Order(s) screen.
If you select one or more status and Sales type, the result display
only the Sales Orders.
But if you select no status and Sales type, the result display all
orders (at least, with Demo data, it displays also the Purchase
Order).

Cimballi

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Ashish Vijaywargiya <vi...@gmail.com>.
Thanks Chirag for your comment.
His comment make me more sense now.
Sorry for creating confusion but Lookup word deviate my mind to Pop-up
screens in ofbiz.

It looks like you are helping Cimballi good so I am moving out.

--
Ashish

On Sat, May 30, 2009 at 11:07 AM, Chirag Manocha <
chirag.manocha@hotwaxmedia.com> wrote:

> Ashish,
> Cimballi is talking about Order List screen in ordermgr.
>
> Regards
> --
> Chirag Manocha
> HotWax Media Pvt. Ltd.
> Website :- www.hotwaxmedia.com
> Contact :- +91-98263-19099
>
>
>
>

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Chirag Manocha <ch...@hotwaxmedia.com>.
Ashish,
Cimballi is talking about Order List screen in ordermgr.

Regards
--
Chirag Manocha
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98263-19099



Ashish Vijaywargiya wrote:
> I am confused from your question.
> What do you mean by Lookup Order(s) screen ?
>
> Are you talking about Find Order Screen or the Screen that comes as a pop up
> where you can search orders (If you are talking about pop up then please let
> us know the exact reference) ?
> If it is the case of Find Order Screen then it is working fine.
>
> I have tried the option suggested by you. Working fine for me on trunk and
> returning one result when Sales Order is being selected with no status type
> being selected.
>
> Are you trying on trunk ? If no please share your revision or release
> version details.
> Thanks !
>
> --
> Ashish
>
>
> On Sat, May 30, 2009 at 10:58 AM, Cimballi <ci...@gmail.com>wrote:
>
>   
>> Hum, I confirm the bug is there. You just have to unselect all Status,
>> keep the Type on "Sales Order", click on Find, and it will return 2
>> orders, a Sales one and a Purchase one, which is not normal as only
>> Sales Order is selected.
>>
>> Cimballi
>>
>>     
>
>   


Re: Bug in Lookup Order(s) screen when no status selected

Posted by Ashish Vijaywargiya <vi...@gmail.com>.
I am confused from your question.
What do you mean by Lookup Order(s) screen ?

Are you talking about Find Order Screen or the Screen that comes as a pop up
where you can search orders (If you are talking about pop up then please let
us know the exact reference) ?
If it is the case of Find Order Screen then it is working fine.

I have tried the option suggested by you. Working fine for me on trunk and
returning one result when Sales Order is being selected with no status type
being selected.

Are you trying on trunk ? If no please share your revision or release
version details.
Thanks !

--
Ashish


On Sat, May 30, 2009 at 10:58 AM, Cimballi <ci...@gmail.com>wrote:

> Hum, I confirm the bug is there. You just have to unselect all Status,
> keep the Type on "Sales Order", click on Find, and it will return 2
> orders, a Sales one and a Purchase one, which is not normal as only
> Sales Order is selected.
>
> Cimballi
>

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Jacques Le Roux <ja...@les7arts.com>.
Done http://docs.ofbiz.org/x/r. If someone fill a bug report and you don't clearly understand it, please send him/her to this 
section

Thanks

Jacques

From: "Jacques Le Roux" <ja...@les7arts.com>
> Cimballi suggested something interesting : there are several kind of contributors. At least bug reporters, as he presented 
> himself, and plain contributors (the ones who follow the Contributors Best Practices).
> We could add this distinction in Contributors Best Practices with a 1st paragragh including some advices, like David's 3 points 
> below.
> Then, by refering to it, we will not have to repeat it over and over, we should get better and consistent bug reports (easier to 
> read since they would follow some kind of rules), me may enhance the paragragh with experience, etc.
> We may even hope that by reading such bug reports in the ML users may even not need to be told how to report bugs (examples works 
> great in real life, an OFBiz is a great example of that :o)
> And finally this is flexible enough for less involved users
>
> My 2cts
>
> Jacques
>
> From: "David E Jones" <da...@hotwaxmedia.com>
>> On May 29, 2009, at 11:39 PM, Cimballi wrote:
>>
>>> Thanks, I was starting to think I was crazy :-)
>>
>> Don't think you're crazy... just think that maybe you didn't provide  enough detail... ;)
>>
>> Bug reports are important and welcome, and as you can see people take  them seriously even when things aren't clear. Part of the 
>> problem is  that OFBiz is a big system and without adequate detail it's easy to do  something completely different that what you 
>> did.
>>
>> To help make them clear you might try including the following:
>>
>> 1. what you did (including detailed steps to reproduce, with URLs,  field names, exact quotes of labels, etc)
>> 2. what you expected to happen
>> 3. what actually happened (again including exact quotes of error  messages, etc)
>>
>> -David
>>
>
> 



Re: Bug in Lookup Order(s) screen when no status selected

Posted by Jacques Le Roux <ja...@les7arts.com>.
Cimballi suggested something interesting : there are several kind of contributors. At least bug reporters, as he presented himself, 
and plain contributors (the ones who follow the Contributors Best Practices).
We could add this distinction in Contributors Best Practices with a 1st paragragh including some advices, like David's 3 points 
below.
Then, by refering to it, we will not have to repeat it over and over, we should get better and consistent bug reports (easier to 
read since they would follow some kind of rules), me may enhance the paragragh with experience, etc.
We may even hope that by reading such bug reports in the ML users may even not need to be told how to report bugs (examples works 
great in real life, an OFBiz is a great example of that :o)
And finally this is flexible enough for less involved users

My 2cts

Jacques

From: "David E Jones" <da...@hotwaxmedia.com>
> On May 29, 2009, at 11:39 PM, Cimballi wrote:
>
>> Thanks, I was starting to think I was crazy :-)
>
> Don't think you're crazy... just think that maybe you didn't provide  enough detail... ;)
>
> Bug reports are important and welcome, and as you can see people take  them seriously even when things aren't clear. Part of the 
> problem is  that OFBiz is a big system and without adequate detail it's easy to do  something completely different that what you 
> did.
>
> To help make them clear you might try including the following:
>
> 1. what you did (including detailed steps to reproduce, with URLs,  field names, exact quotes of labels, etc)
> 2. what you expected to happen
> 3. what actually happened (again including exact quotes of error  messages, etc)
>
> -David
> 



Re: Bug in Lookup Order(s) screen when no status selected

Posted by David E Jones <da...@hotwaxmedia.com>.
On May 29, 2009, at 11:39 PM, Cimballi wrote:

> Thanks, I was starting to think I was crazy :-)

Don't think you're crazy... just think that maybe you didn't provide  
enough detail... ;)

Bug reports are important and welcome, and as you can see people take  
them seriously even when things aren't clear. Part of the problem is  
that OFBiz is a big system and without adequate detail it's easy to do  
something completely different that what you did.

To help make them clear you might try including the following:

1. what you did (including detailed steps to reproduce, with URLs,  
field names, exact quotes of labels, etc)
2. what you expected to happen
3. what actually happened (again including exact quotes of error  
messages, etc)

-David


Re: Bug in Lookup Order(s) screen when no status selected

Posted by Ashish Vijaywargiya <vi...@gmail.com>.
Please see my comments inline:

On Sat, May 30, 2009 at 11:09 AM, Cimballi <ci...@gmail.com>wrote:

> Thanks, I was starting to think I was crazy :-)
>
> For Ashish, I was speaking about this screen :
> https://demo904.ofbiz.org/ordermgr/control/main
>
> And the problem is for demo904.ofbiz.org and demo.ofbiz.org
>
> One message for the commiters, right now I am doing a lot of tests, I
> just posted 3-5 bugs (or possible bugs) on the users list today.
> Usually, I take care to test several times before posting the message.
> For now I will only send emails, I will not open issues nor send
> patches, not enough expert for that, maybe later... So, thanks to take
> my emails in account, I will try to post enough information to be
> clear each time.


Thanks a lot Cimballi for your contribution in this area.
We appreciate your help to report bugs on the mailing list and will wait for
your contribution using JIRA :-).

I am sure your bugs will be resolved in a day or so as they comes on the
mailing list.
So send as much as bug you can send, the idea behind doing so is that we can
have more stable code in OFBiz trunk and release branch.

--
Ashish

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Cimballi <ci...@gmail.com>.
Thanks, I was starting to think I was crazy :-)

For Ashish, I was speaking about this screen :
https://demo904.ofbiz.org/ordermgr/control/main

And the problem is for demo904.ofbiz.org and demo.ofbiz.org

One message for the commiters, right now I am doing a lot of tests, I
just posted 3-5 bugs (or possible bugs) on the users list today.
Usually, I take care to test several times before posting the message.
For now I will only send emails, I will not open issues nor send
patches, not enough expert for that, maybe later... So, thanks to take
my emails in account, I will try to post enough information to be
clear each time.

Cimballi

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Chirag Manocha <ch...@hotwaxmedia.com>.
Yes, this time you are correct, when unselect all the status and 
selecting "Sales Order" it is giving both type of order.

But its working fine for "select one or more status".

Regards
-- 
Chirag Manocha
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98263-19099



Cimballi wrote:
> Hum, I confirm the bug is there. You just have to unselect all Status,
> keep the Type on "Sales Order", click on Find, and it will return 2
> orders, a Sales one and a Purchase one, which is not normal as only
> Sales Order is selected.
>
> Cimballi
>
>
> On Sat, May 30, 2009 at 12:20 AM, Chirag Manocha
> <ch...@hotwaxmedia.com> wrote:
>   
>> Working perfectly fine for me on Demo Server.
>>
>> Cimballi,
>> Please do check once more. You might missed something.
>>
>> Regards
>> --
>> Chirag Manocha
>> HotWax Media Pvt. Ltd.
>> Website :- www.hotwaxmedia.com
>> Contact :- +91-98263-19099
>>
>>
>>
>> Cimballi wrote:
>>     
>>> Hi,
>>>
>>> There is another bug in the Lookup Order(s) screen.
>>> If you select one or more status and Sales type, the result display
>>> only the Sales Orders.
>>> But if you select no status and Sales type, the result display all
>>> orders (at least, with Demo data, it displays also the Purchase
>>> Order).
>>>
>>> Cimballi
>>>
>>>       
>>     


Re: Bug in Lookup Order(s) screen when no status selected

Posted by Cimballi <ci...@gmail.com>.
Hum, I confirm the bug is there. You just have to unselect all Status,
keep the Type on "Sales Order", click on Find, and it will return 2
orders, a Sales one and a Purchase one, which is not normal as only
Sales Order is selected.

Cimballi


On Sat, May 30, 2009 at 12:20 AM, Chirag Manocha
<ch...@hotwaxmedia.com> wrote:
> Working perfectly fine for me on Demo Server.
>
> Cimballi,
> Please do check once more. You might missed something.
>
> Regards
> --
> Chirag Manocha
> HotWax Media Pvt. Ltd.
> Website :- www.hotwaxmedia.com
> Contact :- +91-98263-19099
>
>
>
> Cimballi wrote:
>>
>> Hi,
>>
>> There is another bug in the Lookup Order(s) screen.
>> If you select one or more status and Sales type, the result display
>> only the Sales Orders.
>> But if you select no status and Sales type, the result display all
>> orders (at least, with Demo data, it displays also the Purchase
>> Order).
>>
>> Cimballi
>>
>
>

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Chirag Manocha <ch...@hotwaxmedia.com>.
Working perfectly fine for me on Demo Server.

Cimballi,
Please do check once more. You might missed something.

Regards
--
Chirag Manocha
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98263-19099



Cimballi wrote:
> Hi,
>
> There is another bug in the Lookup Order(s) screen.
> If you select one or more status and Sales type, the result display
> only the Sales Orders.
> But if you select no status and Sales type, the result display all
> orders (at least, with Demo data, it displays also the Purchase
> Order).
>
> Cimballi
>   


Re: Bug in Lookup Order(s) screen when no status selected

Posted by Cimballi <ci...@gmail.com>.
Right Chirag, it seems ok now on both sites, but something should have
changed since yesterday...

Cimballi


On Tue, Aug 25, 2009 at 12:59 AM, Chirag
Manocha<ch...@hotwaxmedia.com> wrote:
> Hi Jacques/Cimballi,
> This is perfectly working fine on
> https://demo904.ofbiz.org/ordermgr/control/orderlist as well as
> https://demo.ofbiz.org/ordermgr/control/orderlist.
>
> OFBiz-2590 was there for this. and code committed in r784145 & r784147
> There might be some confusion Cimballi. Please cross check.
>
>
> Regards
> --
> Chirag Manocha
> HotWax Media Pvt. Ltd.
> Website :- www.hotwaxmedia.com
> Contact :- +91-98263-19099
>
>
>
> Cimballi wrote:
>>
>> Hi Jacques,
>>
>> On this url "https://demo904.ofbiz.org/ordermgr/control/orderlist", I
>> was not able to reproduce the problem but I found this, if you select
>> no status and "Purchase order", you have again the message "You do not
>> have permission to view this page (it needs "ORDERMGR_VIEW" or
>> "ORDERMGR_ADMIN").".
>> And I have the same problem here
>> "https://demo.ofbiz.org/ordermgr/control/orderlist".
>>
>> Cimballi
>>
>>
>> On Mon, Aug 24, 2009 at 8:19 AM, Jacques Le Roux<ja...@free.fr>
>> wrote:
>>
>>>
>>> Hi,
>>>
>>> It seems that this bug has been fixed. Else please provide more
>>> informations. Is there a Jira issue opens for that ?
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>> From: "Cimballi" <ci...@cimballi.net>
>>>
>>>>
>>>> Hi,
>>>>
>>>> There is another bug in the Lookup Order(s) screen.
>>>> If you select one or more status and Sales type, the result display
>>>> only the Sales Orders.
>>>> But if you select no status and Sales type, the result display all
>>>> orders (at least, with Demo data, it displays also the Purchase
>>>> Order).
>>>>
>>>> Cimballi
>>>>
>>>>
>

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Chirag Manocha <ch...@hotwaxmedia.com>.
Hi Jacques/Cimballi,
This is perfectly working fine on 
https://demo904.ofbiz.org/ordermgr/control/orderlist as well as 
https://demo.ofbiz.org/ordermgr/control/orderlist.

OFBiz-2590 was there for this. and code committed in r784145 & r784147
There might be some confusion Cimballi. Please cross check.


Regards
-- 
Chirag Manocha
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98263-19099



Cimballi wrote:
> Hi Jacques,
>
> On this url "https://demo904.ofbiz.org/ordermgr/control/orderlist", I
> was not able to reproduce the problem but I found this, if you select
> no status and "Purchase order", you have again the message "You do not
> have permission to view this page (it needs "ORDERMGR_VIEW" or
> "ORDERMGR_ADMIN").".
> And I have the same problem here
> "https://demo.ofbiz.org/ordermgr/control/orderlist".
>
> Cimballi
>
>
> On Mon, Aug 24, 2009 at 8:19 AM, Jacques Le Roux<ja...@free.fr> wrote:
>   
>> Hi,
>>
>> It seems that this bug has been fixed. Else please provide more
>> informations. Is there a Jira issue opens for that ?
>>
>> Thanks
>>
>> Jacques
>>
>> From: "Cimballi" <ci...@cimballi.net>
>>     
>>> Hi,
>>>
>>> There is another bug in the Lookup Order(s) screen.
>>> If you select one or more status and Sales type, the result display
>>> only the Sales Orders.
>>> But if you select no status and Sales type, the result display all
>>> orders (at least, with Demo data, it displays also the Purchase
>>> Order).
>>>
>>> Cimballi
>>>
>>>       

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Cimballi <ci...@cimballi.net>.
Hi Jacques !

It seems there is still a problem related to this bug.
If you unselect all the checkboxes, you have the message :
"You do not have permission to view this page (it needs
"ORDERMGR_VIEW" or "ORDERMGR_ADMIN")."

You also have the problem is you select only a filter, and in fact I
have doubts that the filter is really working.

Version : ofbiz-rel9.04-2009-09-25-v818777

Cimballi


On Sat, Aug 29, 2009 at 7:52 AM, Cimballi <ci...@cimballi.net> wrote:
> And thanks for solving ! ;-)
>
>
> On Sat, Aug 29, 2009 at 4:21 AM, Jacques Le Roux<ja...@free.fr> wrote:
>> Hi Cimballi,
>>
>> It's fixed in trunk at r808787, R9.04 r809105
>> Thank for reporting
>>
>> Jacques
>

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Cimballi <ci...@cimballi.net>.
And thanks for solving ! ;-)


On Sat, Aug 29, 2009 at 4:21 AM, Jacques Le Roux<ja...@free.fr> wrote:
> Hi Cimballi,
>
> It's fixed in trunk at r808787, R9.04 r809105
> Thank for reporting
>
> Jacques

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Jacques Le Roux <ja...@free.fr>.
Hi Cimballi,

It's fixed in trunk at r808787, R9.04 r809105  

Thank for reporting

Jacques

From: "Cimballi" <ci...@gmail.com>
> Hi Jacques,
> 
> On this url "https://demo904.ofbiz.org/ordermgr/control/orderlist", I
> was not able to reproduce the problem but I found this, if you select
> no status and "Purchase order", you have again the message "You do not
> have permission to view this page (it needs "ORDERMGR_VIEW" or
> "ORDERMGR_ADMIN").".
> And I have the same problem here
> "https://demo.ofbiz.org/ordermgr/control/orderlist".
> 
> Cimballi
> 
> 
> On Mon, Aug 24, 2009 at 8:19 AM, Jacques Le Roux<ja...@free.fr> wrote:
>> Hi,
>>
>> It seems that this bug has been fixed. Else please provide more
>> informations. Is there a Jira issue opens for that ?
>>
>> Thanks
>>
>> Jacques
>>
>> From: "Cimballi" <ci...@cimballi.net>
>>>
>>> Hi,
>>>
>>> There is another bug in the Lookup Order(s) screen.
>>> If you select one or more status and Sales type, the result display
>>> only the Sales Orders.
>>> But if you select no status and Sales type, the result display all
>>> orders (at least, with Demo data, it displays also the Purchase
>>> Order).
>>>
>>> Cimballi
>>>
>>
>

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Cimballi <ci...@gmail.com>.
Hi Jacques,

On this url "https://demo904.ofbiz.org/ordermgr/control/orderlist", I
was not able to reproduce the problem but I found this, if you select
no status and "Purchase order", you have again the message "You do not
have permission to view this page (it needs "ORDERMGR_VIEW" or
"ORDERMGR_ADMIN").".
And I have the same problem here
"https://demo.ofbiz.org/ordermgr/control/orderlist".

Cimballi


On Mon, Aug 24, 2009 at 8:19 AM, Jacques Le Roux<ja...@free.fr> wrote:
> Hi,
>
> It seems that this bug has been fixed. Else please provide more
> informations. Is there a Jira issue opens for that ?
>
> Thanks
>
> Jacques
>
> From: "Cimballi" <ci...@cimballi.net>
>>
>> Hi,
>>
>> There is another bug in the Lookup Order(s) screen.
>> If you select one or more status and Sales type, the result display
>> only the Sales Orders.
>> But if you select no status and Sales type, the result display all
>> orders (at least, with Demo data, it displays also the Purchase
>> Order).
>>
>> Cimballi
>>
>

Re: Bug in Lookup Order(s) screen when no status selected

Posted by Jacques Le Roux <ja...@free.fr>.
Hi,

It seems that this bug has been fixed. Else please provide more informations. Is there a Jira issue opens for that ?

Thanks

Jacques

From: "Cimballi" <ci...@cimballi.net>
> Hi,
> 
> There is another bug in the Lookup Order(s) screen.
> If you select one or more status and Sales type, the result display
> only the Sales Orders.
> But if you select no status and Sales type, the result display all
> orders (at least, with Demo data, it displays also the Purchase
> Order).
> 
> Cimballi
>