You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/07/31 00:10:54 UTC
Review Request 36956: Created a test abstraction for preparing test
rootfs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36956/
-----------------------------------------------------------
Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
Bugs: MESOS-3179
https://issues.apache.org/jira/browse/MESOS-3179
Repository: mesos
Description
-------
Created a test abstraction for preparing test rootfs.
Diffs
-----
src/tests/containerizer/launch_tests.cpp 73c8c5fa17936b1bab4817e9f1e691144e87c35f
src/tests/containerizer/rootfs.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/36956/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 36956: Created a test abstraction for preparing
test rootfs.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36956/#review93933
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36929, 36930, 36954, 36956]
All tests passed.
- Mesos ReviewBot
On Aug. 3, 2015, 5:18 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36956/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 5:18 p.m.)
>
>
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-3179
> https://issues.apache.org/jira/browse/MESOS-3179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created a test abstraction for preparing test rootfs.
>
>
> Diffs
> -----
>
> src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec
> src/tests/containerizer/launch_tests.cpp 73c8c5fa17936b1bab4817e9f1e691144e87c35f
> src/tests/containerizer/rootfs.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36956/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 36956: Created a test abstraction for preparing
test rootfs.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36956/#review93921
-----------------------------------------------------------
Ship it!
src/tests/containerizer/rootfs.hpp (line 66)
<https://reviews.apache.org/r/36956/#comment148358>
Just wanted to comment on this because this is related to a previous discussion.
For `Path`, <stout/path.hpp> is not directly included and I don't think os.hpp is explicitly "exporting" `Path` through its APIs.
I am less certain about what to do with the calls to the functions under `os::`. We have intentionally separated out these headers such as <os/stat.hpp> but in order to use `os::mkdir` we need to include <os.hpp> which includes everything under `stout/os/`.
Maybe we should continue to refactor all these basic functions out of os.hpp so we only include os.hpp when we intentionally want to include everything.
- Jiang Yan Xu
On Aug. 3, 2015, 10:18 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36956/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 10:18 a.m.)
>
>
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-3179
> https://issues.apache.org/jira/browse/MESOS-3179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created a test abstraction for preparing test rootfs.
>
>
> Diffs
> -----
>
> src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec
> src/tests/containerizer/launch_tests.cpp 73c8c5fa17936b1bab4817e9f1e691144e87c35f
> src/tests/containerizer/rootfs.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36956/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 36956: Created a test abstraction for preparing
test rootfs.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36956/
-----------------------------------------------------------
(Updated Aug. 3, 2015, 5:18 p.m.)
Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Added the missing header in the makefile.
Bugs: MESOS-3179
https://issues.apache.org/jira/browse/MESOS-3179
Repository: mesos
Description
-------
Created a test abstraction for preparing test rootfs.
Diffs (updated)
-----
src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec
src/tests/containerizer/launch_tests.cpp 73c8c5fa17936b1bab4817e9f1e691144e87c35f
src/tests/containerizer/rootfs.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/36956/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 36956: Created a test abstraction for preparing
test rootfs.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36956/
-----------------------------------------------------------
(Updated July 31, 2015, 10:23 p.m.)
Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-3179
https://issues.apache.org/jira/browse/MESOS-3179
Repository: mesos
Description
-------
Created a test abstraction for preparing test rootfs.
Diffs (updated)
-----
src/tests/containerizer/launch_tests.cpp 73c8c5fa17936b1bab4817e9f1e691144e87c35f
src/tests/containerizer/rootfs.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/36956/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu