[Bug 7577] New: FreeMail.pm is keeping hits between different messages

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7577

            Bug ID: 7577
           Summary: FreeMail.pm is keeping hits between different messages
           Product: Spamassassin
           Version: 3.4 SVN branch
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Plugins
          Assignee: dev@spamassassin.apache.org
          Reporter: kmcgrail@apache.org
  Target Milestone: Undefined

Thanks to Paul Murphy for helping tracking this down.

The per-msg-status description for the rule is not being cleared between runs:

FreeMail.pm:

    if ($pms->{main}->{conf}->{freemail_add_describe_email}) {

        $email =~ s/\@/[at]/g;

        $pms->got_hit($rulename, "", description => $desc." ($email)", ruletype
=> 'eval');

    }

The new hits are appended to the old ones, which is fine in the same
invocation, but when the SA process is persistent and handles multiple
messages, something needs to reset the state in PMS once the message is fully
processed.  It seems that the dynamic rule descriptions are persisting.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7577] FreeMail.pm is keeping hits between different messages

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7577

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.4.3
                 CC|                            |kmcgrail@apache.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7577] FreeMail.pm is keeping hits between different messages

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7577

Henrik Krohns <he...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hege@hege.li
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Henrik Krohns <he...@hege.li> ---
Isn't this fixed ages ago?
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6617

I tested with current trunk and 3.4 spamd, and all works as designed (only ever
see one email in the rule report). Checking and debugging code, got_hit()
simply does not permanently save the description.

Without any concrete examples of the problem and running environment, I have to
conclude this as duplicate.

*** This bug has been marked as a duplicate of bug 6617 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7577] FreeMail.pm is keeping hits between different messages

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7577

--- Comment #2 from Henrik Krohns <he...@hege.li> ---
Ok I actually stumbled on this accidently... it seems to be in effect when
running spamassassin for multiple files. Spamd didn't do it..

We should call test_log instead of hacking suffix to got_hit.

Sending        spamassassin-3.4/lib/Mail/SpamAssassin/Plugin/FreeMail.pm
Sending        spamassassin-3.4/lib/Mail/SpamAssassin/Plugin/HashBL.pm
Sending        spamassassin-3.4/lib/Mail/SpamAssassin/Plugin/Phishing.pm
Sending        trunk/lib/Mail/SpamAssassin/Plugin/FreeMail.pm
Sending        trunk/lib/Mail/SpamAssassin/Plugin/HashBL.pm
Sending        trunk/lib/Mail/SpamAssassin/Plugin/Phishing.pm
Transmitting file data ......done
Committing transaction...
Committed revision 1844813.

-- 
You are receiving this mail because:
You are the assignee for the bug.