[GitHub] [druid] jihoonson commented on a change in pull request #10732: Add a config for monitorScheduler type

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #10732:
URL: https://github.com/apache/druid/pull/10732#discussion_r555262086



##########
File path: server/src/main/java/org/apache/druid/server/metrics/DruidMonitorSchedulerConfig.java
##########
@@ -28,9 +29,17 @@
  */
 public class DruidMonitorSchedulerConfig extends MonitorSchedulerConfig
 {
+  @JsonProperty
+  private String schedulerClassName = ClockDriftSafeMonitorScheduler.class.getName();

Review comment:
       It was changed in https://github.com/apache/druid/pull/10448, not in this PR. This PR is just to make it configurable because I'm not sure how stable it is. As noted in https://github.com/apache/druid/pull/10448#issuecomment-756367474, CronScheduler seems to have a not-bad test coverage and worked well in my testing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org