You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by vipul1409 <gi...@git.apache.org> on 2016/08/24 13:21:09 UTC
[GitHub] zeppelin pull request #1357: ZEPPELIN-1364: Return only the ran paragraph de...
GitHub user vipul1409 opened a pull request:
https://github.com/apache/zeppelin/pull/1357
ZEPPELIN-1364: Return only the ran paragraph details for indiviual paragraph run.
### What is this PR for?
If you run a note book having lots of paragraphs and few images and svgs. Every paragraph run sends the complete notebook instead of sending the details of just the executed paragraph. We can see good performance gain if we send only the details of ran paragraph.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
https://issues.apache.org/jira/browse/ZEPPELIN-1364
### How should this be tested?
Create a notebook with few large images etc. so that note.json size is around 4 MB and run
%sh ls . It will take very long without this fix.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vipul1409/zeppelin ZEPPELIN-1364
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1357.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1357
----
commit 71eb7d42b07f37202f1969e7fa9be22c7e3bb1f2
Author: Vipul Modi <vi...@qubole.com>
Date: 2016-08-24T13:15:42Z
Return only the ran paragraph details for indiviual paragraph run.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1357: ZEPPELIN-1364: Return only the ran paragraph details f...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1357
@vipul1409 thank you, it sounds interesting! Could you please let know, if it is ready for review?
@Leemoonsoo @corneadoug do you guys see any downsides\side-effects for such change?
Seems like CI is failing for some reason, could you please check it? Usually posting the reason of CI failure speeds up the review process a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1357: ZEPPELIN-1364: Return only the ran paragraph details f...
Posted by vipul1409 <gi...@git.apache.org>.
Github user vipul1409 commented on the issue:
https://github.com/apache/zeppelin/pull/1357
Not needed any more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1357: ZEPPELIN-1364: Return only the ran paragraph details f...
Posted by vipul1409 <gi...@git.apache.org>.
Github user vipul1409 commented on the issue:
https://github.com/apache/zeppelin/pull/1357
Yes It is ready for review.
The reason for CI failure looks unrelated to my changes as the build is failing in npm side and I have not made any JS changes.
The build is passing for few profiles and failing for few looks intermittent.
This is the error.
> [ERROR] npm ERR! Callback called more than once.
> [ERROR] npm ERR!
Any suggestion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1357: ZEPPELIN-1364: Return only the ran paragraph details f...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/1357
Didn't try the changes but definitively +1 for this to enhance performance (tried to imagine side effects but didn't find any atm)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1357: ZEPPELIN-1364: Return only the ran paragraph de...
Posted by vipul1409 <gi...@git.apache.org>.
Github user vipul1409 closed the pull request at:
https://github.com/apache/zeppelin/pull/1357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1357: ZEPPELIN-1364: Return only the ran paragraph details f...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1357
@vipul1409 Can you rebase this PR?
I will run a few tests to see if all the paragraph updates are handled here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---