You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Dian Fu <di...@gmail.com> on 2015/06/04 04:02:08 UTC
Re: Review Request 34883: SQOOP-2378: SQOOP2: Revoke all privilege
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34883/
-----------------------------------------------------------
(Updated June 4, 2015, 2:02 a.m.)
Review request for Sqoop.
Summary (updated)
-----------------
SQOOP-2378: SQOOP2: Revoke all privilege
Repository: sqoop-sqoop2
Description
-------
SQOOP2: Revoke all privilege
Diffs
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java d5c4a8a
shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java 802d206
Diff: https://reviews.apache.org/r/34883/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 34883: SQOOP-2378: SQOOP2: Revoke all privilege
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34883/
-----------------------------------------------------------
(Updated June 4, 2015, 9:38 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
SQOOP2: Revoke all privilege
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java d5c4a8a
shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java 802d206
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 40ed9fc
shell/src/main/resources/shell-resource.properties 62bbbeb
Diff: https://reviews.apache.org/r/34883/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 34883: SQOOP-2378: SQOOP2: Revoke all privilege
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34883/#review86576
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On June 4, 2015, 2:02 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34883/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 2:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP2: Revoke all privilege
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java d5c4a8a
> shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java 802d206
>
> Diff: https://reviews.apache.org/r/34883/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 34883: SQOOP-2378: SQOOP2: Revoke all privilege
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34883/#review86578
-----------------------------------------------------------
Ship it!
Found a couple of more details while testing the patch out.
shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java
<https://reviews.apache.org/r/34883/#comment138636>
NIT: Please don't use wildcards!
shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java
<https://reviews.apache.org/r/34883/#comment138635>
Change message too?
- Abraham Elmahrek
On June 4, 2015, 2:02 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34883/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 2:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP2: Revoke all privilege
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java d5c4a8a
> shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java 802d206
>
> Diff: https://reviews.apache.org/r/34883/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>